You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/02 01:09:47 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request #3252: Re-enable Kafka ssl sasl tests
zhfeng opened a new pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740773721
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Need a new issue, that one was closed and fixed some time ago.
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Ah you're right. It was already disabled on the `main` branch so I guess we should fix it there.
In that case we can probably merge this PR and take care of `KafkaSaslSslIT` on the `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740866380
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I raise https://github.com/apache/camel-quarkus/issues/3254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740773721
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Need a new issue, that one was closed and fixed some time ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng merged pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740792453
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I will raise a new issue to fix these native tests for ```KafkaSaslSslIT``` and ```KafkaSslTest```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740845232
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Ah you're right. It was already disabled on the `main` branch so I guess we should fix it there.
In that case we can probably merge this PR and take care of `KafkaSaslSslIT` on the `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng merged pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740792453
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I will raise a new issue to fix these native tests for ```KafkaSaslSslIT``` and ```KafkaSslTest```.
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
and it should be fixed in main branch ?
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I raise https://github.com/apache/camel-quarkus/issues/3254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740833414
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
and it should be fixed in main branch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740792453
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I will raise a new issue to fix these native tests for ```KafkaSaslSslIT``` and ```KafkaSslTest```.
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
and it should be fixed in main branch ?
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
yeah, I raise https://github.com/apache/camel-quarkus/issues/3254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252#discussion_r740773721
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Need a new issue, that one was closed and fixed some time ago.
##########
File path: integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslIT.java
##########
@@ -16,10 +16,10 @@
*/
package org.apache.camel.quarkus.kafka.sasl;
-import io.quarkus.test.junit.DisabledOnNativeImage;
import io.quarkus.test.junit.NativeImageTest;
+import org.junit.jupiter.api.Disabled;
-@DisabledOnNativeImage("https://github.com/apache/camel-quarkus/issues/3239")
+@Disabled("https://github.com/apache/camel-quarkus/issues/2729")
Review comment:
Ah you're right. It was already disabled on the `main` branch so I guess we should fix it there.
In that case we can probably merge this PR and take care of `KafkaSaslSslIT` on the `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #3252: Re-enable Kafka ssl sasl tests
Posted by GitBox <gi...@apache.org>.
zhfeng merged pull request #3252:
URL: https://github.com/apache/camel-quarkus/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org