[jira] [Commented] (ACCUMULO-4132) TableOperations::listSplits returns Collection TableOperations::addSplits takes SortedSet

["Wil Selwood (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130515#comment-15130515 ] 

Wil Selwood commented on ACCUMULO-4132:
---------------------------------------

This change could work either way. We could change listSplits to return a sorted set or we could change addSplits to take a collection. 

Seeing as addSplits makes a copy of the parameter into an array list and then sorts the list, changing that to take a Collection<Text> would probably be the simplest change and least likely to break any existing code.

> TableOperations::listSplits returns Collection<Text> TableOperations::addSplits takes SortedSet<Text>
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4132
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4132
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Wil Selwood
>            Priority: Minor
>
> When copying the splits from one table to another (we are re-encoding some of the data on route) the TableOperations::listSplits method returns a Collection<Text> however the TableOperations::addSplits method takes a SortedSet<Text>
> Apart from the fact it will change the API this looks like a relatively simple change. If the API change is acceptable I should be able to provide a patch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)