You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by phymbert <gi...@git.apache.org> on 2017/06/23 11:56:15 UTC
[GitHub] logging-log4j2 pull request #86: [LOG4J2-1766] Temporary archived file patte...
GitHub user phymbert opened a pull request:
https://github.com/apache/logging-log4j2/pull/86
[LOG4J2-1766] Temporary archived file pattern during compression
Rebased patch onto master, added documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phymbert/logging-log4j2 LOG4J2-1766
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit af4d3ddd18babe29f3983f83631b36d987cd022c
Author: phymbert <pi...@gmail.com>
Date: 2017-06-23T11:49:43Z
[LOG4J2-1766] Rebase onto master from original jira patch.
Signed-off-by: phymbert <pi...@gmail.com>
commit 33d3cf58b7c5da790170469e6e77e0680c49b934
Author: phymbert <pi...@gmail.com>
Date: 2017-06-23T11:50:24Z
[LOG4J2-1766] Documentation of compressTmpFilePattern
DefaultRolloverStrategy parameter.
Signed-off-by: phymbert <pi...@gmail.com>
commit e583d1ef653569fd97b57a5d156a370396e1116f
Author: phymbert <pi...@gmail.com>
Date: 2017-06-23T11:54:58Z
[LOG4J2-1766] Little formating.
Signed-off-by: phymbert <pi...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #86: [LOG4J2-1766] Temporary archived file pattern duri...
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/86
Depends if the constructors are private or not. For public ones where having a default value for the new constructor doesn't make much sense, deprecation is the way to go. When a sensible default is possible, I wouldn't bother deprecating the old one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #86: [LOG4J2-1766] Temporary archived file pattern duri...
Posted by phymbert <gi...@git.apache.org>.
Github user phymbert commented on the issue:
https://github.com/apache/logging-log4j2/pull/86
Added Builder API for rollover strategies, I introduce new constructors for this additional parameter. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #86: [LOG4J2-1766] Temporary archived file pattern duri...
Posted by phymbert <gi...@git.apache.org>.
Github user phymbert commented on the issue:
https://github.com/apache/logging-log4j2/pull/86
Hi @garydgregory, understood, little question, is it preferable to deprecate existing constructor and create another one or set after instantiate new parameter in the builder ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 pull request #86: [LOG4J2-1766] Temporary archived file patte...
Posted by phymbert <gi...@git.apache.org>.
Github user phymbert closed the pull request at:
https://github.com/apache/logging-log4j2/pull/86
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---