You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2023/01/23 13:03:35 UTC

[GitHub] [lucene] jpountz opened a new pull request, #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

jpountz opened a new pull request, #12101:
URL: https://github.com/apache/lucene/pull/12101

   This method tries to expose an encoded view of vectors, but we shouldn't have this part of our user-facing API. With this change, the way vectors are encoded is entirely on the codec.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #12101:
URL: https://github.com/apache/lucene/pull/12101#issuecomment-1400319320

   This change was more mechanical that I had anticipated thanks to @benwtrent 's recent refactorings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz merged pull request #12101: Remove binaryValue() on VectorValues and ByteVectorValues.

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #12101:
URL: https://github.com/apache/lucene/pull/12101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org