[GitHub] [calcite] rubenada commented on a diff in pull request #3390: [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails

["rubenada (via GitHub)" <gi...@apache.org>]

rubenada commented on code in PR #3390:
URL: https://github.com/apache/calcite/pull/3390#discussion_r1321146914


##########
core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java:
##########
@@ -378,4 +378,28 @@ public void run() {
   interface Action {
     void check(RexBuilder rexBuilder, RexExecutorImpl executor);
   }
+
+  /** Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-5949">[CALCITE-5949]
+   * RexExecutable should properly handle invalid constant expressions in reduction</a>.

Review Comment:
   @arkanovicz could you please align this comment with the latest title / commit message ("RexExecutable should return unchanged original expressions when it fails")?
   Then please squash commits into a single one, and I'll proceed with the merge



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org