You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/09/26 19:16:51 UTC
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11527
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
SENTRY-2413 requires a new configuration:
sentry.db.explicit.grants.permitted to be added into sentry-site*.xml to
specify which privileges are permitted to be granted explicitly.
Testing:
- Ran all FE tests
- Ran authorization E2E tests
Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
---
M fe/src/test/resources/sentry-site.xml.template
M fe/src/test/resources/sentry-site_no_oo.xml.template
M fe/src/test/resources/sentry-site_oo.xml.template
M fe/src/test/resources/sentry-site_oo_nogrant.xml.template
4 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/11527/2
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/820/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 19:42:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3235/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 15:37:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
SENTRY-2413 requires a new configuration:
sentry.db.explicit.grants.permitted to be added into sentry-site*.xml to
specify which privileges are permitted to be granted explicitly.
Testing:
- Ran all FE tests
- Ran authorization E2E tests
Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Reviewed-on: http://gerrit.cloudera.org:8080/11527
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/resources/sentry-site.xml.template
M fe/src/test/resources/sentry-site_no_oo.xml.template
M fe/src/test/resources/sentry-site_oo.xml.template
M fe/src/test/resources/sentry-site_oo_nogrant.xml.template
4 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 19:21:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 19:35:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 2: Code-Review+2
2 +1s from Adam and Csaba. Bumping it to a +2.
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 15:36:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 15:34:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11527 )
Change subject: IMPALA-7631: Add sentry.db.explicit.grants.permitted in sentry-site*.xml
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adac50fe194cb341d49a40915763f70cd81c348
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 15:37:17 +0000
Gerrit-HasComments: No