[GitHub] [trafficcontrol] dangogh commented on a change in pull request #3711: Update/add TO Golang audit logs on non-DS endpoints

[GitBox <gi...@apache.org>]

dangogh commented on a change in pull request #3711: Update/add TO Golang audit logs on non-DS endpoints
URL: https://github.com/apache/trafficcontrol/pull/3711#discussion_r302606716
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/crconfig/handler.go
 ##########
 @@ -175,7 +176,7 @@ func SnapshotHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	api.CreateChangeLogRawTx(api.ApiChange, "Snapshot of CRConfig and Monitor performed for "+cdn, inf.User, inf.Tx.Tx)
+	api.CreateChangeLogRawTx(api.ApiChange, fmt.Sprintf("CDN: %v, ID: %v, ACTION: Snapshot of CRConfig and Monitor", cdn, inf.IntParams["id"]), inf.User, inf.Tx.Tx)
 
 Review comment:
   probably want to avoid using fmt in this situation and especially `%v`.  It has to use reflection to fill in the string and and Sprintf doesn't add that much clarity...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services