[GitHub] [spark] yaooqinn commented on a change in pull request #31864: [SPARK-34772][SQL] RebaseDateTime loadRebaseRecords should use Spark classloader instead of context

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #31864:
URL: https://github.com/apache/spark/pull/31864#discussion_r597017982



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
##########
@@ -338,6 +338,28 @@ class HiveSparkSubmitSuite
       unusedJar.toString)
     runSparkSubmit(argsForShowTables)
   }
+
+  test("SPARK-34772: RebaseDateTime loadRebaseRecords should use Spark classloader " +
+    "instead of context") {
+    val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
+
+    // We need specify the metastore database location in case of conflict with other hive version

Review comment:
       nit: `need` ->`need to`..... `version` ->`versions.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org