You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/05 21:03:12 UTC

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1) 

Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3848

to review the following change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................

Rename Remote Bootstrap to Tablet Copy (part 1)

This does a bunch of automated substitutions of the terminology,
renaming "remote bootstrap" to "tablet copy". This commit does
not rename the files yet, so that it's easier to review without
combining a file name change with the file content change.

This is an incompatible change since some flag and metric names are
changed. Another follow-up will have to add release notes.

Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
---
M docs/contributing.adoc
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/remote_bootstrap-test-base.h
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service-test.cc
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/remote_bootstrap_service.h
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/remote_bootstrap_session.cc
M src/kudu/tserver/remote_bootstrap_session.h
M src/kudu/tserver/tablet_peer_lookup.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver.proto
47 files changed, 641 insertions(+), 641 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3848/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2720/

-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 1:

yea, I'm also currently going through and doing a bunch of manual cleanup/edits for things that my find-replace missed. Was planning on doing that in a second patch, and then the file renames in a third.

-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 2: Code-Review+1

> Build Started http://104.196.14.100/job/kudu-gerrit/2720/

The renaming of files like remote_bootstrap_xxx --> tablet_copy_xxx is scheduled for Part2, isn't it?

-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3848

to look at the new patch set (#2).

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................

Rename Remote Bootstrap to Tablet Copy (part 1)

This does a bunch of automated substitutions of the terminology,
renaming "remote bootstrap" to "tablet copy". This commit does
not rename the files yet, so that it's easier to review without
combining a file name change with the file content change.

This is an incompatible change since some flag and metric names are
changed. Another follow-up will have to add release notes.

Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
---
M docs/contributing.adoc
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/remote_bootstrap-test-base.h
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service-test.cc
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/remote_bootstrap_service.h
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/remote_bootstrap_session.cc
M src/kudu/tserver/remote_bootstrap_session.h
M src/kudu/tserver/tablet_peer_lookup.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver.proto
46 files changed, 640 insertions(+), 640 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3848/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2719/

-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Rename Remote Bootstrap to Tablet Copy (part 1)

This does a bunch of automated substitutions of the terminology,
renaming "remote bootstrap" to "tablet copy". This commit does
not rename the files yet, so that it's easier to review without
combining a file name change with the file content change.

This is an incompatible change since some flag and metric names are
changed. Another follow-up will have to add release notes.

Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Reviewed-on: http://gerrit.cloudera.org:8080/3848
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M docs/contributing.adoc
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/remote_bootstrap-test-base.h
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service-test.cc
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/remote_bootstrap_service.h
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/remote_bootstrap_session.cc
M src/kudu/tserver/remote_bootstrap_session.h
M src/kudu/tserver/tablet_peer_lookup.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver.proto
46 files changed, 640 insertions(+), 640 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Alexey Serbin: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)

Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.

Change subject: Rename Remote Bootstrap to Tablet Copy (part 1)
......................................................................


Patch Set 3:

(2 comments)

Docs and whitepaper look fine, with the exception of the specific comments below.

http://gerrit.cloudera.org:8080/#/c/3848/3/docs/design-docs/README.md
File docs/design-docs/README.md:

Line 29: | [Raft tablet copy design](raft-remote-bootstrap.md) | Consensus | N/A |
Should you change this here? Is the decision still in flight? If this has already been decided, I'm not sure we should go back and change history.


http://gerrit.cloudera.org:8080/#/c/3848/3/docs/design-docs/raft-remote-bootstrap.md
File docs/design-docs/raft-remote-bootstrap.md:

You should also rename this file if you are changing this.


-- 
To view, visit http://gerrit.cloudera.org:8080/3848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes