You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/27 14:15:29 UTC
[GitHub] [flink] AHeise opened a new pull request #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
AHeise opened a new pull request #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
URL: https://github.com/apache/flink/pull/10952
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
[FLINK-15777][filesystem] Using the filesystem's classpath to determine Hadoop version.
FLINK-14170 introduced Hadoop version check to support older versions with limited functionality. However, the fix checks the Hadoop version of the system classloader and not of the plugin (of the actual used filesystem).
The version checks will fail when there is a Hadoop version in the classpath of Flink, independent of the bundled version of the filesystem.
On a recent EMR setup with lingering Hadoop 2.6 libraries, this mean that you cannot write to S3 with StreamingFileSink.
## Brief change log
- Make truncate handle non-static and receive it from actually used filesystem
- Use filesystem classloader for version checks
## Verifying this change
Not tested
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no /** don't know)
- The S3 file system connector: (**yes** / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371272320
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -55,7 +53,7 @@
private static final long LEASE_TIMEOUT = 100_000L;
- private static Method truncateHandle;
+ private final Method truncateHandle;
Review comment:
`@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146228708 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146242547 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146228708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630)
* baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146242547) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371270839
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
}
+
+ return truncateMethod;
}
- private static boolean truncate(final FileSystem hadoopFs, final Path file, final long length) throws IOException {
- if (!HadoopUtils.isMinHadoopVersion(2, 7)) {
- throw new IllegalStateException("Truncation is not available in hadoop version < 2.7 , You are on Hadoop " + VersionInfo.getVersion());
+ private static boolean truncate(
Review comment:
change to non static method and use `truncateHandle` from the instance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-584605200
I think this is not valid anymore, so closing the PR. Thanks for pointing this out @kl0u. Please re-open this if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371300568
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
}
+
+ return truncateMethod;
}
- private static boolean truncate(final FileSystem hadoopFs, final Path file, final long length) throws IOException {
- if (!HadoopUtils.isMinHadoopVersion(2, 7)) {
- throw new IllegalStateException("Truncation is not available in hadoop version < 2.7 , You are on Hadoop " + VersionInfo.getVersion());
+ private static boolean truncate(
Review comment:
> Do we need some new test coverage?
Yes, but I don't have a good idea for a non-complicated test setup. In theory, we would need to have a test matrix where we co-ship Flink with hadoop 2.6 and 2.8 and have plugins with hadoop 2.6 and 2.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371300568
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
}
+
+ return truncateMethod;
}
- private static boolean truncate(final FileSystem hadoopFs, final Path file, final long length) throws IOException {
- if (!HadoopUtils.isMinHadoopVersion(2, 7)) {
- throw new IllegalStateException("Truncation is not available in hadoop version < 2.7 , You are on Hadoop " + VersionInfo.getVersion());
+ private static boolean truncate(
Review comment:
> Do we need some new test coverage?
Yes, but I don't have a good idea for a non-complicated test setup. In theory, we would need to have a test matrix where we co-ship Flink with hadoop 2.6 and 2.8 and have plugins with hadoop 2.6 and 2.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146228708 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146242547 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146228708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630)
* baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146242547) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski closed pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
pnowojski closed pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371301769
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
}
+
+ return truncateMethod;
}
- private static boolean truncate(final FileSystem hadoopFs, final Path file, final long length) throws IOException {
- if (!HadoopUtils.isMinHadoopVersion(2, 7)) {
- throw new IllegalStateException("Truncation is not available in hadoop version < 2.7 , You are on Hadoop " + VersionInfo.getVersion());
+ private static boolean truncate(
Review comment:
Yes, that's what I'd wanted to do but unfortunately, `HadoopRecoverableWriter` accesses the static `HadoopRecoverableFsDataOutputStream.HadoopFsCommitter` which in turn invokes the truncate.
We could factor out a common TruncateWrapper though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146228708 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146242547 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632 TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146228708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630)
* baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146242547) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
URL: https://github.com/apache/flink/pull/10952#issuecomment-578766804
Ideas for test setup are welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371299272
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
Review comment:
`getMethod` is only return public members.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10952: [FLINK-15777][filesystem] Using the filesystem's classpath to determi…
URL: https://github.com/apache/flink/pull/10952#issuecomment-578767806
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 43c462b0fa265dfa9bec3eaeacebcf5ba0ee6d63 (Mon Jan 27 14:17:53 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15777).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578797697
Do we need some new test coverage?
Yes, but I don't have a good idea for a non-complicated test setup. In theory, we would need to have a test matrix where we co-ship Flink with hadoop 2.6 and 2.8 and have plugins with hadoop 2.6 and 2.8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-584204491
@AHeise Is this PR still valid? I am asking because the attached JIRA has been closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146228708 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146228708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#discussion_r371270053
##########
File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableFsDataOutputStream.java
##########
@@ -175,44 +172,39 @@ private static void safelyTruncateFile(
}
}
- private static void ensureTruncateInitialized() throws FlinkRuntimeException {
- if (HadoopUtils.isMinHadoopVersion(2, 7) && truncateHandle == null) {
- Method truncateMethod;
+ private static Method findTrunacteMethod(FileSystem fs) throws FlinkRuntimeException {
+ Method truncateMethod = null;
+ if (HadoopUtils.isMinHadoopVersion(fs.getClass().getClassLoader(), 2, 7)) {
try {
- truncateMethod = FileSystem.class.getMethod("truncate", Path.class, long.class);
- }
- catch (NoSuchMethodException e) {
+ truncateMethod = fs.getClass().getMethod("truncate", Path.class, long.class);
+ } catch (NoSuchMethodException e) {
throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
}
-
- if (!Modifier.isPublic(truncateMethod.getModifiers())) {
- throw new FlinkRuntimeException("Could not find a public truncate method on the Hadoop File System.");
- }
-
- truncateHandle = truncateMethod;
Review comment:
Don't we need this check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10952:
[FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10952: [FLINK-15777][filesystem]Determine Hadoop version with fs classpath.
URL: https://github.com/apache/flink/pull/10952#issuecomment-578788155
<!--
Meta data
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146228708 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:35f6da3aae4dd29a8dabb97953a29035d9c9f44a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630 TriggerType:PUSH TriggerID:35f6da3aae4dd29a8dabb97953a29035d9c9f44a
Hash:baeecaa8980eb5b53083b7d9daa3365a4f6c7901 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:baeecaa8980eb5b53083b7d9daa3365a4f6c7901
-->
## CI report:
* 35f6da3aae4dd29a8dabb97953a29035d9c9f44a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146228708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4630)
* baeecaa8980eb5b53083b7d9daa3365a4f6c7901 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services