You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/01/23 04:32:28 UTC
[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20358
[SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bit_length and octet_length
## What changes were proposed in this pull request?
We need to override the prettyName for bit_length and octet_length for getting the expected auto-generated alias name.
## How was this patch tested?
The existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark test2.3More
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20358
----
commit 4f4032d52e25b4dd83bdbe223e32625992fbe88b
Author: gatorsmile <ga...@...>
Date: 2018-01-23T04:28:25Z
fix
commit 53d74a203ccbafd0942d83b647957e07dd8f1d31
Author: gatorsmile <ga...@...>
Date: 2018-01-23T04:28:54Z
indent
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20358
cc @kiszk @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20358
Merged to master and branch-2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20358
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20358
**[Test build #86510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86510/testReport)** for PR 20358 at commit [`53d74a2`](https://github.com/apache/spark/commit/53d74a203ccbafd0942d83b647957e07dd8f1d31).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20358#discussion_r163145263
--- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -141,7 +141,7 @@ statement
(LIKE? pattern=STRING)? #showTables
| SHOW TABLE EXTENDED ((FROM | IN) db=identifier)?
LIKE pattern=STRING partitionSpec? #showTable
- | SHOW DATABASES (LIKE? pattern=STRING)? #showDatabases
+ | SHOW DATABASES (LIKE? pattern=STRING)? #showDatabases
--- End diff --
Nit: seems unrelated?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20358
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20358
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86510/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/122/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20358
**[Test build #86510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86510/testReport)** for PR 20358 at commit [`53d74a2`](https://github.com/apache/spark/commit/53d74a203ccbafd0942d83b647957e07dd8f1d31).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20358: [SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20358
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org