You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/13 05:14:56 UTC
[GitHub] [helix] zhangmeng916 opened a new issue #1264: Change TestInstanceAutoJoin to adapt to cloud environment
zhangmeng916 opened a new issue #1264:
URL: https://github.com/apache/helix/issues/1264
**Describe the bug**
The previous test `testAutoRegistrationShouldFailWhenWaitingRespons` in TestInstanceAutoJoin will fail in github test, although it always pass locally. The reason is that the test was written with the assumption that it is only run in on-prem environment and auto registration will fail with no cloud response returned. However, github tests are run in cloud environment, and the auto registration will succeed. So we need to change the tests to make it adapt to both on-prem and cloud environment.
**To Reproduce**
Run the test in github.
**Expected behavior**
Auto registration succeeds and live instance is added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 closed issue #1264: Change TestInstanceAutoJoin to adapt to cloud environment
Posted by GitBox <gi...@apache.org>.
zhangmeng916 closed issue #1264:
URL: https://github.com/apache/helix/issues/1264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1264: Change TestInstanceAutoJoin to adapt to cloud environment
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1264:
URL: https://github.com/apache/helix/issues/1264#issuecomment-673706435
This is the same issue as https://github.com/apache/helix/issues/1260, which has the details of why we believe so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org