You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by od...@apache.org on 2009/10/12 16:21:41 UTC
svn commit: r824353 - in
/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility:
AccessibleAction.java AccessibleRelation.java
Author: odeakin
Date: Mon Oct 12 14:21:41 2009
New Revision: 824353
URL: http://svn.apache.org/viewvc?rev=824353&view=rev
Log:
Remove unnecessary calls to new String(String).
Modified:
harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java?rev=824353&r1=824352&r2=824353&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java (original)
+++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java Mon Oct 12 14:21:41 2009
@@ -18,9 +18,9 @@
package javax.accessibility;
public interface AccessibleAction {
- static final String TOGGLE_EXPAND = new String("toggle expand"); //$NON-NLS-1$
- static final String INCREMENT = new String("increment"); //$NON-NLS-1$
- static final String DECREMENT = new String("decrement"); //$NON-NLS-1$
+ static final String TOGGLE_EXPAND = "toggle expand"; //$NON-NLS-1$
+ static final String INCREMENT = "increment"; //$NON-NLS-1$
+ static final String DECREMENT = "decrement"; //$NON-NLS-1$
int getAccessibleActionCount();
Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java?rev=824353&r1=824352&r2=824353&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java (original)
+++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java Mon Oct 12 14:21:41 2009
@@ -19,11 +19,11 @@
public class AccessibleRelation extends AccessibleBundle {
- public static final String LABEL_FOR = new String("labelFor"); //$NON-NLS-1$
- public static final String LABELED_BY = new String("labeledBy"); //$NON-NLS-1$
- public static final String MEMBER_OF = new String("memberOf"); //$NON-NLS-1$
- public static final String CONTROLLER_FOR = new String("controllerFor"); //$NON-NLS-1$
- public static final String CONTROLLED_BY = new String("controlledBy"); //$NON-NLS-1$
+ public static final String LABEL_FOR = "labelFor"; //$NON-NLS-1$
+ public static final String LABELED_BY = "labeledBy"; //$NON-NLS-1$
+ public static final String MEMBER_OF = "memberOf"; //$NON-NLS-1$
+ public static final String CONTROLLER_FOR = "controllerFor"; //$NON-NLS-1$
+ public static final String CONTROLLED_BY = "controlledBy"; //$NON-NLS-1$
public static final String FLOWS_TO = "flowsTo"; //$NON-NLS-1$
public static final String FLOWS_FROM = "flowsFrom"; //$NON-NLS-1$
public static final String SUBWINDOW_OF = "subwindowOf"; //$NON-NLS-1$
Re: svn commit: r824353 - in /harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility:
AccessibleAction.java AccessibleRelation.java
Posted by Oliver Deakin <ol...@googlemail.com>.
Thanks Tim, I'm in the process of reverting the commit now (and Ill add
a comment to the code to make sure it doesn't happen again).
Regards,
Oliver
Tim Ellison wrote:
> They were put in for a reason ;-) See HARMONY-6008.
>
> Tim
>
> On 12/Oct/2009 15:21, odeakin@apache.org wrote:
>
>> Author: odeakin
>> Date: Mon Oct 12 14:21:41 2009
>> New Revision: 824353
>>
>> URL: http://svn.apache.org/viewvc?rev=824353&view=rev
>> Log:
>> Remove unnecessary calls to new String(String).
>>
>> Modified:
>> harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
>> harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
>>
>> Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
>> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java?rev=824353&r1=824352&r2=824353&view=diff
>> ==============================================================================
>> --- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java (original)
>> +++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java Mon Oct 12 14:21:41 2009
>> @@ -18,9 +18,9 @@
>> package javax.accessibility;
>>
>> public interface AccessibleAction {
>> - static final String TOGGLE_EXPAND = new String("toggle expand"); //$NON-NLS-1$
>> - static final String INCREMENT = new String("increment"); //$NON-NLS-1$
>> - static final String DECREMENT = new String("decrement"); //$NON-NLS-1$
>> + static final String TOGGLE_EXPAND = "toggle expand"; //$NON-NLS-1$
>> + static final String INCREMENT = "increment"; //$NON-NLS-1$
>> + static final String DECREMENT = "decrement"; //$NON-NLS-1$
>>
>> int getAccessibleActionCount();
>>
>>
>> Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
>> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java?rev=824353&r1=824352&r2=824353&view=diff
>> ==============================================================================
>> --- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java (original)
>> +++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java Mon Oct 12 14:21:41 2009
>> @@ -19,11 +19,11 @@
>>
>>
>> public class AccessibleRelation extends AccessibleBundle {
>> - public static final String LABEL_FOR = new String("labelFor"); //$NON-NLS-1$
>> - public static final String LABELED_BY = new String("labeledBy"); //$NON-NLS-1$
>> - public static final String MEMBER_OF = new String("memberOf"); //$NON-NLS-1$
>> - public static final String CONTROLLER_FOR = new String("controllerFor"); //$NON-NLS-1$
>> - public static final String CONTROLLED_BY = new String("controlledBy"); //$NON-NLS-1$
>> + public static final String LABEL_FOR = "labelFor"; //$NON-NLS-1$
>> + public static final String LABELED_BY = "labeledBy"; //$NON-NLS-1$
>> + public static final String MEMBER_OF = "memberOf"; //$NON-NLS-1$
>> + public static final String CONTROLLER_FOR = "controllerFor"; //$NON-NLS-1$
>> + public static final String CONTROLLED_BY = "controlledBy"; //$NON-NLS-1$
>> public static final String FLOWS_TO = "flowsTo"; //$NON-NLS-1$
>> public static final String FLOWS_FROM = "flowsFrom"; //$NON-NLS-1$
>> public static final String SUBWINDOW_OF = "subwindowOf"; //$NON-NLS-1$
>>
>>
>>
>>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: svn commit: r824353 - in /harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility:
AccessibleAction.java AccessibleRelation.java
Posted by Tim Ellison <t....@gmail.com>.
They were put in for a reason ;-) See HARMONY-6008.
Tim
On 12/Oct/2009 15:21, odeakin@apache.org wrote:
> Author: odeakin
> Date: Mon Oct 12 14:21:41 2009
> New Revision: 824353
>
> URL: http://svn.apache.org/viewvc?rev=824353&view=rev
> Log:
> Remove unnecessary calls to new String(String).
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
> harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
>
> Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java?rev=824353&r1=824352&r2=824353&view=diff
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java (original)
> +++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleAction.java Mon Oct 12 14:21:41 2009
> @@ -18,9 +18,9 @@
> package javax.accessibility;
>
> public interface AccessibleAction {
> - static final String TOGGLE_EXPAND = new String("toggle expand"); //$NON-NLS-1$
> - static final String INCREMENT = new String("increment"); //$NON-NLS-1$
> - static final String DECREMENT = new String("decrement"); //$NON-NLS-1$
> + static final String TOGGLE_EXPAND = "toggle expand"; //$NON-NLS-1$
> + static final String INCREMENT = "increment"; //$NON-NLS-1$
> + static final String DECREMENT = "decrement"; //$NON-NLS-1$
>
> int getAccessibleActionCount();
>
>
> Modified: harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java?rev=824353&r1=824352&r2=824353&view=diff
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java (original)
> +++ harmony/enhanced/classlib/trunk/modules/accessibility/src/main/java/javax/accessibility/AccessibleRelation.java Mon Oct 12 14:21:41 2009
> @@ -19,11 +19,11 @@
>
>
> public class AccessibleRelation extends AccessibleBundle {
> - public static final String LABEL_FOR = new String("labelFor"); //$NON-NLS-1$
> - public static final String LABELED_BY = new String("labeledBy"); //$NON-NLS-1$
> - public static final String MEMBER_OF = new String("memberOf"); //$NON-NLS-1$
> - public static final String CONTROLLER_FOR = new String("controllerFor"); //$NON-NLS-1$
> - public static final String CONTROLLED_BY = new String("controlledBy"); //$NON-NLS-1$
> + public static final String LABEL_FOR = "labelFor"; //$NON-NLS-1$
> + public static final String LABELED_BY = "labeledBy"; //$NON-NLS-1$
> + public static final String MEMBER_OF = "memberOf"; //$NON-NLS-1$
> + public static final String CONTROLLER_FOR = "controllerFor"; //$NON-NLS-1$
> + public static final String CONTROLLED_BY = "controlledBy"; //$NON-NLS-1$
> public static final String FLOWS_TO = "flowsTo"; //$NON-NLS-1$
> public static final String FLOWS_FROM = "flowsFrom"; //$NON-NLS-1$
> public static final String SUBWINDOW_OF = "subwindowOf"; //$NON-NLS-1$
>
>
>