You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/10 03:00:52 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17018: [cleanup][broker] Fix typo & Revert irrelevant code.

michaeljmarshall commented on code in PR #17018:
URL: https://github.com/apache/pulsar/pull/17018#discussion_r941963904


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -550,14 +550,15 @@ public final synchronized void readEntriesComplete(List<Entry> entries, Object c
         if (serviceConfig.isDispatcherDispatchMessagesInSubscriptionThread()) {
             // setting sendInProgress here, because sendMessagesToConsumers will be executed
             // in a separate thread, and we want to prevent more reads
+            havePendingRead = true;

Review Comment:
   That is a good point. We could handle the `RejectedExecutionException` if we think it will happen. As you said though, the queue is unbounded, so I don't think it is a case we _have_ to handle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org