You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/26 14:07:09 UTC

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #287: [DO NOT MERGE] SUREFIRE-1782 Exclude explicitly configured env vars

Tibor17 commented on a change in pull request #287:
URL: https://github.com/apache/maven-surefire/pull/287#discussion_r415318730



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/lazytestprovider/OutputStreamFlushableCommandline.java
##########
@@ -53,19 +56,27 @@ public OutputStreamFlushableCommandline()
     public OutputStreamFlushableCommandline( String[] excludedEnvironmentVariables )
     {
         this.excludedEnvironmentVariables = new ConcurrentLinkedDeque<>();
+        this.addedEnvironmentVariables = new HashSet<>(  );

Review comment:
       try to rewrite to `addedEnvironmentVariables = new HashSet<>();`
   without `this` and space in constructor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org