You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/27 13:46:05 UTC

[GitHub] [mynewt-core] vikrant-proxy commented on a change in pull request #2627: ipc nrf5340 flash

vikrant-proxy commented on a change in pull request #2627:
URL: https://github.com/apache/mynewt-core/pull/2627#discussion_r677465530



##########
File path: hw/bsp/nordic_pca10095_net/src/hal_bsp.c
##########
@@ -48,13 +48,18 @@ hal_bsp_flash_dev(uint8_t id)
      * Internal flash mapped to id 0.
      */
     if (id == 0) {
-        return &nrf5340_net_flash_dev;
+        return &nrf5340_flash_dev;
     }
 #if MCUBOOT_MYNEWT
     if (id == 1) {
         return &nrf5340_net_vflash_dev.nv_flash;
     }
 #endif
+#if MYNEWT_VAL(IPC_NRF5340_FLASH_CLIENT)

Review comment:
       should this have been `IPC_NRF5340_FLASH_SERVER` given appcore is the client?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org