[jira] [Commented] (IGNITE-14121) Implement ability to generate configuration trees from arbitrary sources

["Sergey Chugunov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281704#comment-17281704 ] 

Sergey Chugunov commented on IGNITE-14121:
------------------------------------------

[~ibessonov],

I took a look at PR, in general it looks good to me.

There are several points that need discussion and may even be changed:
# ConfigurationUtil API doesn't look uniform to me: methods fillFromPrefixMap and patch are very close by semantics (the former creates the whole tree while the latter changes part of the tree) but their signatures are significantly different. We may think of generalizing them so they always accept target tree and ConfigurationSource with changes (or full content) for the target tree.
# Also ConfigurationUtil is not part of public API and should be moved to some internal package.

At the same time I suggest to merge this patch now and discuss proposed changes later (and implement them with separate tasks).

> Implement ability to generate configuration trees from arbitrary sources
> ------------------------------------------------------------------------
>
>                 Key: IGNITE-14121
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14121
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Ivan Bessonov
>            Assignee: Ivan Bessonov
>            Priority: Major
>             Fix For: 3.0.0-alpha2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Prototype is already present here: [https://github.com/apache/ignite-3/pull/34/files]
> Now we need to adapt it to current configuration code and implement automatic generation of construction method's implementations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)