You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/15 02:35:06 UTC
[kudu-CR] macOS: update brew install instructions
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5508
to review the following change.
Change subject: macOS: update brew install instructions
......................................................................
macOS: update brew install instructions
krb5 is available through the brew/dupes tap.
Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/5508/1
--
To view, visit http://gerrit.cloudera.org:8080/5508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] macOS: update brew install instructions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: macOS: update brew install instructions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5508/1/docs/installation.adoc
File docs/installation.adoc:
Line 536: $ brew tap homebrew/dupes
I thought that was the repo which was there by default. Is homebrew/core is there by default only?
--
To view, visit http://gerrit.cloudera.org:8080/5508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] macOS: update brew install instructions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: macOS: update brew install instructions
......................................................................
macOS: update brew install instructions
krb5 is available through the brew/dupes tap.
Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
Reviewed-on: http://gerrit.cloudera.org:8080/5508
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] macOS: update brew install instructions
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: macOS: update brew install instructions
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5508/1/docs/installation.adoc
File docs/installation.adoc:
Line 536: $ brew tap homebrew/dupes
> I thought that was the repo which was there by default. Is homebrew/core
Apparently it's not enabled by default, or at least some users don't have it enabled.
--
To view, visit http://gerrit.cloudera.org:8080/5508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a8d28f3fbce2dff526934bd16436e54333cc5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes