You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/28 13:35:14 UTC
[GitHub] [spark] sekikn opened a new pull request #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
sekikn opened a new pull request #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR replaces the method calls of `toSet.toSeq` with `distinct`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`toSet.toSeq` is intended to make its elements unique but a bit verbose. Using `distinct` instead is easier to understand and improves readability.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Tested with the existing unit tests and found no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605536878
I would just have merged to master at this time, but it is so trivial that almost surely won't matter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503453
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25242/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605534775
Thanks! Merged to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605448478
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503449
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
kiszk commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605502663
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605448478
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503453
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25242/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503267
**[Test build #120536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120536/testReport)** for PR 28062 at commit [`92f871b`](https://github.com/apache/spark/commit/92f871bd84be41deed018896e74348e58e2c3b79).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503449
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605448592
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605520771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120536/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605520516
**[Test build #120536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120536/testReport)** for PR 28062 at commit [`92f871b`](https://github.com/apache/spark/commit/92f871bd84be41deed018896e74348e58e2c3b79).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28062: [SPARK-31292][CORE][SQL]
Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605538073
Yea, since too minor & trivial, I've merged it to 3.0, too. If any problem, plz revert it from 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605520768
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605520768
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605503267
**[Test build #120536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120536/testReport)** for PR 28062 at commit [`92f871b`](https://github.com/apache/spark/commit/92f871bd84be41deed018896e74348e58e2c3b79).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605448592
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28062:
[SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28062: [SPARK-31292][CORE][SQL] Replace toSet.toSeq with distinct for readability
URL: https://github.com/apache/spark/pull/28062#issuecomment-605520771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120536/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org