You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2009/06/22 17:25:08 UTC
[jira] Created: (FELIX-1266) [gogo] Provide a maven build for gogo
[gogo] Provide a maven build for gogo
-------------------------------------
Key: FELIX-1266
URL: https://issues.apache.org/jira/browse/FELIX-1266
Project: Felix
Issue Type: Task
Components: Gogo
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Issue Comment Edited: (FELIX-1266) [gogo] Provide a maven
build for gogo
Posted by Derek Baum <de...@paremus.com>.
Yes, I realised this myself shortly after posting, but have been off-line
until now.
thanks,
Derek
2009/6/25 Filippo Diotalevi (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723943#action_12723943]
>
> Filippo Diotalevi edited comment on FELIX-1266 at 6/25/09 1:27 AM:
> -------------------------------------------------------------------
>
> Hi Derek, if you look at my previous comment, it's a java assertion
> failing. The reason you don't see errors with ant, is that you don't run
> your tests with the "-ea" VM option to enable assertion evaluation.
> Maven use the option by default, that explains the error.
>
> The attached patch fix the problem.
>
> was (Author: fdiotalevi):
> Hi Derek, if you look at my previous comment, it's a java assertion
> failing. The reason you don't see the test with ant, is that you don't run
> your tests with the "-ea" VM option to enable assertion evaluation.
> Maven use the option by default, that explains the error.
>
> The attached patch fix the problem.
>
> > [gogo] Provide a maven build for gogo
> > -------------------------------------
> >
> > Key: FELIX-1266
> > URL: https://issues.apache.org/jira/browse/FELIX-1266
> > Project: Felix
> > Issue Type: Task
> > Components: Gogo
> > Reporter: Guillaume Nodet
> > Assignee: Guillaume Nodet
> > Attachments: build.xml, FELIX-1266.txt
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (FELIX-1266) [gogo] Provide a maven build for
gogo
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723070#action_12723070 ]
Richard S. Hall commented on FELIX-1266:
----------------------------------------
I agree, it is better to reduce dependencies for core pieces like this.
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1266) [gogo] Provide a maven build for
gogo
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722891#action_12722891 ]
Guillaume Nodet commented on FELIX-1266:
----------------------------------------
URL: http://svn.apache.org/viewvc?rev=787421&view=rev
I've put a maven pom, but:
* the test fails in maven
* the generated bundle is unusable because the DS entries are not correctly set
I'd like to get rid of the DS dependency and just use a plain OSGi BundleActivator to minimize the depdendencies...
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-1266) [gogo] Provide a maven
build for gogo
Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723943#action_12723943 ]
Filippo Diotalevi edited comment on FELIX-1266 at 6/25/09 1:27 AM:
-------------------------------------------------------------------
Hi Derek, if you look at my previous comment, it's a java assertion failing. The reason you don't see errors with ant, is that you don't run your tests with the "-ea" VM option to enable assertion evaluation.
Maven use the option by default, that explains the error.
The attached patch fix the problem.
was (Author: fdiotalevi):
Hi Derek, if you look at my previous comment, it's a java assertion failing. The reason you don't see the test with ant, is that you don't run your tests with the "-ea" VM option to enable assertion evaluation.
Maven use the option by default, that explains the error.
The attached patch fix the problem.
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Attachments: build.xml, FELIX-1266.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1266) [gogo] Provide a maven build for gogo
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-1266.
------------------------------------
Resolution: Fixed
I've tried to put gogo in a usable state with maven.
The structure is kinda the same as for the shell subproject, though we might want to add a new module for the telnet stuff.
And thx for the patch, Filippo !
URL: http://svn.apache.org/viewvc?rev=789948&view=rev
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Attachments: build.xml, FELIX-1266.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1266) [gogo] Provide a maven build for gogo
Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filippo Diotalevi updated FELIX-1266:
-------------------------------------
Attachment: FELIX-1266.txt
The maven test failure is caused by a (java) assert failure at ThreadIOImpl.java:113
If I understand correctly the problem is when the second, third, ... Pipe of a closure is created ( see [1], method connect(Pipe) ), the next.setErr(...) method is not called, thus not initializing the "err" printstream
The submitted patch initialize the err printstream.
[1] http://svn.apache.org/repos/asf/felix/trunk/gogo/src/main/java/org/apache/felix/gogo/shell/runtime/Pipe.java
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Attachments: FELIX-1266.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1266) [gogo] Provide a maven build for
gogo
Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723943#action_12723943 ]
Filippo Diotalevi commented on FELIX-1266:
------------------------------------------
Hi Derek, if you look at my previous comment, it's a java assertion failing. The reason you don't see the test with ant, is that you don't run your tests with the "-ea" VM option to enable assertion evaluation.
Maven use the option by default, that explains the error.
The attached patch fix the problem.
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Attachments: build.xml, FELIX-1266.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1266) [gogo] Provide a maven build for gogo
Posted by "Derek Baum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Derek Baum updated FELIX-1266:
------------------------------
Attachment: build.xml
Hmmm... the test failure appears to be _caused_ by maven; running junit directly works fine.
Using the attached build.xml (and editing it to point at your location for junit.jar) gives:
[derek@delboy gogo]$ ant
Buildfile: build.xml
test:
[junit] Running org.apache.felix.gogo.shell.runtime.TestParser
[junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 0.082 sec
[junit] Running org.apache.felix.gogo.threadio.TestThreadIO
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.03 sec
BUILD SUCCESSFUL
Total time: 0 seconds
I am still investigating how to fix this.
Derek
> [gogo] Provide a maven build for gogo
> -------------------------------------
>
> Key: FELIX-1266
> URL: https://issues.apache.org/jira/browse/FELIX-1266
> Project: Felix
> Issue Type: Task
> Components: Gogo
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Attachments: build.xml, FELIX-1266.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.