[GitHub] [airflow] ashb commented on a change in pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI
URL: https://github.com/apache/airflow/pull/5516#discussion_r299697422
 
 

 ##########
 File path: airflow/www/templates/appbuilder/flash.html
 ##########
 @@ -0,0 +1,68 @@
+<!-- Adapted from: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/templates/appbuilder/flash.html -->
+
+<link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='css/flash.css') }}">
+
+<!-- Split array into two arrays: one about Broken DAG, another normal alert  -->
+{% with messages = get_flashed_messages(with_categories=true) %}
+    {% if messages %}
+
+        {% set broken_dag_messages = [] %}
+        {% set other_messages = [] %}
+
+        {% for category, m in messages %}
+            {% if m.startswith('Broken DAG') %}
 
 Review comment:
   What is `category` here? Can we set that when we put the flash so that we don't have to depend on string-prefix matching if we change the format of that "broken dag" message

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services