[GitHub] [submarine] jiwq commented on a change in pull request #433: SUBMARINE-656. Fix the wrong message when creating k8s object fail

[GitBox <gi...@apache.org>]

jiwq commented on a change in pull request #433:
URL: https://github.com/apache/submarine/pull/433#discussion_r502522018



##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -126,7 +127,7 @@ public Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeE
       throw new SubmarineRuntimeException(400, e.getMessage());
     } catch (ApiException e) {
       LOG.error("K8s submitter: parse Job object failed by " + e.getMessage(), e);
-      throw new SubmarineRuntimeException(e.getCode(), e.getMessage());
+      throw new SubmarineRuntimeException(400, "K8s submitter: parse Job object failed by " + e.getMessage());

Review comment:
       Why change the code to 400? I think should use the code responded by upstream.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org