You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2025/10/10 19:41:04 UTC
[PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
reschke opened a new pull request, #300:
URL: https://github.com/apache/jackrabbit/pull/300
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #300:
URL: https://github.com/apache/jackrabbit/pull/300#discussion_r2422641204
##########
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/Base64.java:
##########
@@ -27,9 +27,14 @@
import java.io.Writer;
import java.io.BufferedWriter;
import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
/**
* <code>Base64</code> provides Base64 encoding/decoding of strings and streams.
+ * <p>
+ * See <a href="https://datatracker.ietf.org/doc/html/rfc4648#section-4">RFC 4648, Section 4</a>.
+ * <p>
+ * See {@link java.util.Base64} for a JDK alternative.
Review Comment:
Because of all the convenience methods.
Maybe we can deprecate *some* if the methods though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #300:
URL: https://github.com/apache/jackrabbit/pull/300#discussion_r2422641204
##########
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/Base64.java:
##########
@@ -27,9 +27,14 @@
import java.io.Writer;
import java.io.BufferedWriter;
import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
/**
* <code>Base64</code> provides Base64 encoding/decoding of strings and streams.
+ * <p>
+ * See <a href="https://datatracker.ietf.org/doc/html/rfc4648#section-4">RFC 4648, Section 4</a>.
+ * <p>
+ * See {@link java.util.Base64} for a JDK alternative.
Review Comment:
Because of all the convenience methods.
Maybe we can deprecate *some* though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #300:
URL: https://github.com/apache/jackrabbit/pull/300#issuecomment-3392208686
## [](https://sonarcloud.io/dashboard?id=apache_jackrabbit&pullRequest=300) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_jackrabbit&pullRequest=300&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_jackrabbit&pullRequest=300&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_jackrabbit&pullRequest=300&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_jackrabbit&pullRequest=300&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_jackrabbit&pullRequest=300&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_jackrabbit&pullRequest=300)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #300:
URL: https://github.com/apache/jackrabbit/pull/300#discussion_r2422431962
##########
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/Base64.java:
##########
@@ -27,9 +27,14 @@
import java.io.Writer;
import java.io.BufferedWriter;
import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
/**
* <code>Base64</code> provides Base64 encoding/decoding of strings and streams.
+ * <p>
+ * See <a href="https://datatracker.ietf.org/doc/html/rfc4648#section-4">RFC 4648, Section 4</a>.
+ * <p>
+ * See {@link java.util.Base64} for a JDK alternative.
Review Comment:
Why not deprecate it in favor of Java one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCR-5197: cleanup o.a.j.util.Base64 and update Javadoc [jackrabbit]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #300:
URL: https://github.com/apache/jackrabbit/pull/300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org