[GitHub] [arrow-datafusion] epsio-banay commented on pull request #6601: Prioritize UDF over scalar built-in function in case of function name…

["epsio-banay (via GitHub)" <gi...@apache.org>]

epsio-banay commented on PR #6601:
URL: https://github.com/apache/arrow-datafusion/pull/6601#issuecomment-1586891902

   > I think this branch has a logical merge conflict with some of the changes on master. If I applied this diff locally the tests passed:
   > 
   > ```diff
   > diff --git a/datafusion/core/tests/sql/udf.rs b/datafusion/core/tests/sql/udf.rs
   > index 0ecd5d0fd..eb76c3417 100644
   > --- a/datafusion/core/tests/sql/udf.rs
   > +++ b/datafusion/core/tests/sql/udf.rs
   > @@ -185,7 +185,7 @@ async fn scalar_udf_override_built_in_scalar_function() -> Result<()> {
   >  
   >      let batch = RecordBatch::try_new(
   >          Arc::new(schema.clone()),
   > -        vec![Arc::new(Int32Array::from(vec![-100]))],
   > +        vec![Arc::new(Int32Array::from_slice([-100]))],
   >      )?;
   >      let ctx = SessionContext::new();
   >  
   > ```
   
   rebased and fixed:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org