You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/09/11 04:56:07 UTC
[kudu-CR] [mini chronyd] add reference NTP servers in config
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14211
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
[mini_chronyd] add reference NTP servers in config
This patch adds the ability to specify reference NTP servers in chronyd
configuration via the mini_chronyd wrapper. New tests to cover
the newly introduced functionality are added as well.
Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
---
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/clock/test/mini_chronyd.h
3 files changed, 232 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/14211/1
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini chronyd] add reference NTP servers in config
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14211 )
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
[mini_chronyd] add reference NTP servers in config
This patch adds the ability to specify reference NTP servers in chronyd
configuration via the mini_chronyd wrapper. New tests to cover
the newly introduced functionality are added as well.
Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Reviewed-on: http://gerrit.cloudera.org:8080/14211
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/clock/test/mini_chronyd.h
3 files changed, 230 insertions(+), 11 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini chronyd] add reference NTP servers in config
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14211 )
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Sep 2019 17:21:32 +0000
Gerrit-HasComments: No
[kudu-CR] [mini chronyd] add reference NTP servers in config
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14211 )
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc
File src/kudu/clock/test/mini_chronyd-test.cc:
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc@47
PS1, Line 47: should cannot
Nit: should not?
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc@77
PS1, Line 77: // Make sure the client communicated with the server.
What's this comment referring to?
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd.h
File src/kudu/clock/test/mini_chronyd.h:
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd.h@139
PS1, Line 139: when
Nit: if
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Sep 2019 16:50:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini chronyd] add reference NTP servers in config
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14211 )
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc
File src/kudu/clock/test/mini_chronyd-test.cc:
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc@47
PS1, Line 47: should cannot
> Nit: should not?
Done
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd-test.cc@77
PS1, Line 77: // Make sure the client communicated with the server.
> What's this comment referring to?
Whoops, that's some extra-line. Removed.
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd.h
File src/kudu/clock/test/mini_chronyd.h:
http://gerrit.cloudera.org:8080/#/c/14211/1/src/kudu/clock/test/mini_chronyd.h@139
PS1, Line 139: when
> Nit: if
Done
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Sep 2019 17:00:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini chronyd] add reference NTP servers in config
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14211
to look at the new patch set (#2).
Change subject: [mini_chronyd] add reference NTP servers in config
......................................................................
[mini_chronyd] add reference NTP servers in config
This patch adds the ability to specify reference NTP servers in chronyd
configuration via the mini_chronyd wrapper. New tests to cover
the newly introduced functionality are added as well.
Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
---
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/clock/test/mini_chronyd.h
3 files changed, 230 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/14211/2
--
To view, visit http://gerrit.cloudera.org:8080/14211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d517bab98afd20ae63f2ff18635c1f579c39adb
Gerrit-Change-Number: 14211
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)