[GitHub] [flink] zhijiangW edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

[GitBox <gi...@apache.org>]

zhijiangW edited a comment on issue #9646:  [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
URL: https://github.com/apache/flink/pull/9646#issuecomment-532503656
 
 
   Sorry for missing the following comments. I agree with the general above points.
   
   On runtime side it does not care about the specific `SourceReader` interface. The runtime only interacts with source operator via `#emitNext` and `#available` methods atm. As for how the source operator further interacts with the internal source reader, the runtime does not need to understand it.
   
   We can ignore the `SourceReader` related details in this PR. The possible meaningful point in this PR is that I try to pass through whether the runtime proposed `DataOutput` argument via `operator#emitNext` can satisfy well for the future `SourceReader`. So I construct a unit test for verifying it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services