[GitHub] [arrow] icexelloss commented on a diff in pull request #35514: GH-35515: [WIP][C++][Python] Add non decomposable aggregation UDF

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #35514:
URL: https://github.com/apache/arrow/pull/35514#discussion_r1188787758


##########
python/pyarrow/src/arrow/python/udf.cc:
##########
@@ -65,6 +70,26 @@ struct PythonUdfKernelInit {
   std::shared_ptr<OwnedRefNoGIL> function;
 };
 
+struct ScalarUdfAggregator : public compute::KernelState {

Review Comment:
   "Scalar" as supposed to the "grouped" aggregator which has difference interface:
   https://github.com/apache/arrow/blob/main/cpp/src/arrow/compute/kernels/hash_aggregate.cc#L66



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org