You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/01/19 11:48:00 UTC

[jira] [Commented] (AVRO-3248) Rust: Support named types in UnionSchema

    [ https://issues.apache.org/jira/browse/AVRO-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478607#comment-17478607 ] 

ASF subversion and git services commented on AVRO-3248:
-------------------------------------------------------

Commit 49c6e1067c937d066503be9c7f4032fb03f67474 in avro's branch refs/heads/master from Litao Lu
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=49c6e10 ]

AVRO-3248: Rust: Support named types in UnionSchema (#1396)

* AVRO-3248: Rust: Support named types in UnionSchema

previously union does not support named types, and we will get error if
we add 2 records into 1 UnionSchema.

* AVRO-3248: Fix a typo in error message

* AVRO-3248: Give better names for the schemata as string

* AVRO-3248: More better names for variables

* AVRO-3248: Code formatting

* AVRO-3248 Fix formatting & build

Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>

* AVRO-3248: Fix generate_interop_data and formatting

Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>

* AVRO-3248: Fix some regressions after the rebase to master

Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>

* AVRO-3248 Fix the position in the Union for the Double value

Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>

Co-authored-by: Martin Grigorov <ma...@users.noreply.github.com>
Co-authored-by: Martin Tzvetanov Grigorov <mg...@apache.org>

> Rust: Support named types in UnionSchema
> ----------------------------------------
>
>                 Key: AVRO-3248
>                 URL: https://issues.apache.org/jira/browse/AVRO-3248
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: Lu Litao
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> currently there's no support for named type in avro's Union type in rust.
> as stated in this comment of the UnionSchma struct
> {quote}// Used to ensure uniqueness of schema inputs, and provide constant time finding of the
>  // schema index given a value.
>  // **NOTE** that this approach does not work for named types, and will have to be modified
>  // to support that. A simple solution is to also keep a mapping of the names used.
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)