[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #741: MINIFICPP-1139 Implemented.

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #741: MINIFICPP-1139 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/741#discussion_r383333144
 
 

 ##########
 File path: extensions/windows-event-log/ConsumeWindowsEventLog.h
 ##########
 @@ -101,14 +100,12 @@ class ConsumeWindowsEventLog : public core::Processor
   
 
 protected:
-  bool subscribe(const std::shared_ptr<core::ProcessContext> &context);
-  void unsubscribe();
-  int processQueue(const std::shared_ptr<core::ProcessSession> &session);
+  void processEventsAfterBookmark(core::ProcessSession& session);
+  void processEventRender(const EventRender& renderedData, core::ProcessSession& session);
   wel::WindowsEventLogHandler getEventLogHandler(const std::string & name);
   bool insertHeaderName(wel::METADATA_NAMES &header, const std::string &key, const std::string &value);
   void LogWindowsError();
-  void processEvent(EVT_HANDLE eventHandle);
-  bool processEventsAfterBookmark(EVT_HANDLE hEventResults, const std::wstring& channel, const std::wstring& query);
+  bool processEvent(EVT_HANDLE eventHandle, EventRender& renderedData);
 
 Review comment:
   This member function deserves a Doxygen-style comment describing the behavior and the meaning of the return value, since it's not obvious by looking at the signature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services