You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nathan Visagan (JIRA)" <ji...@apache.org> on 2012/10/17 17:40:04 UTC

[jira] [Created] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud

Nathan Visagan created SOLR-3960:
------------------------------------

             Summary: Searching: PostFilter plugins ignored by solr cloud
                 Key: SOLR-3960
                 URL: https://issues.apache.org/jira/browse/SOLR-3960
             Project: Solr
          Issue Type: Bug
          Components: search, SolrCloud
    Affects Versions: 4.0-BETA
         Environment: Linux / jre 1.6
            Reporter: Nathan Visagan


When specifying the cloud options (-DzkRun -DnumShards=n) solr query does not consider the PostFilter.
For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
When I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter. [pf is an instance of SolrIndexSearcher.ProcessedFilter]. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-3960:
---------------------------

    Attachment: SOLR-3960.patch

slight test improvement to exercise distributed grouping both with a regular filter and with a post-filter
                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504311#comment-13504311 ] 

Yonik Seeley commented on SOLR-3960:
------------------------------------

Looks good Hoss!
                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>            Assignee: Hoss Man
>              Labels: patch
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-3960:
---------------------------

    Attachment: SOLR-3960.patch

grouping and postfilters are two areas of internals that i'm not really familiar with, but based on Nathan's problem description and great job pointing out the methods he noticed not playing nicely, i was able to create a test case demonstrating the problem, and then take a blind stab at a fix.

would definitely appreciate more eyeballs on this
                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>         Attachments: SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504342#comment-13504342 ] 

Commit Tag Bot commented on SOLR-3960:
--------------------------------------

[branch_4x commit] Chris M. Hostetter
http://svn.apache.org/viewvc?view=revision&revision=1413983

SOLR-3960: Fixed a bug where Distributed Grouping ignored PostFilters (merge r1413975)


                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>            Assignee: Hoss Man
>              Labels: patch
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504325#comment-13504325 ] 

Commit Tag Bot commented on SOLR-3960:
--------------------------------------

[trunk commit] Chris M. Hostetter
http://svn.apache.org/viewvc?view=revision&revision=1413975

SOLR-3960: Fixed a bug where Distributed Grouping ignored PostFilters


                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>            Assignee: Hoss Man
>              Labels: patch
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Visagan updated SOLR-3960:
---------------------------------

    Description: 
When specifying the cloud options (-DzkRun -DnumShards=n) solr query does not consider the PostFilter.
For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
When I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter. pf is an instance of SolrIndexSearcher.ProcessedFilter. 

  was:
When specifying the cloud options (-DzkRun -DnumShards=n) solr query does not consider the PostFilter.
For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
When I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter. [pf is an instance of SolrIndexSearcher.ProcessedFilter]. 

    
> Searching: PostFilter plugins ignored by solr cloud
> ---------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) solr query does not consider the PostFilter.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> When I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter. pf is an instance of SolrIndexSearcher.ProcessedFilter. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Visagan updated SOLR-3960:
---------------------------------

    Summary: Searching: PostFilter plugins ignored by solr cloud for queries with grouping  (was: Searching: PostFilter plugins ignored by solr cloud)
    
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man reassigned SOLR-3960:
------------------------------

    Assignee: Hoss Man
    
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>            Assignee: Hoss Man
>              Labels: patch
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478903#comment-13478903 ] 

Nathan Visagan commented on SOLR-3960:
--------------------------------------

You are correct. Its only happening with grouping and solr cloud options. For example if I send a query like q=*:*&group=true&group.field=language&fq={!pf1}. 
Sorry. The confusion earlier happened because I had some default grouping enabled for all the queries in the solrconfig select handler.
                
> Searching: PostFilter plugins ignored by solr cloud
> ---------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Comment Edited] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478903#comment-13478903 ] 

Nathan Visagan edited comment on SOLR-3960 at 10/18/12 10:57 AM:
-----------------------------------------------------------------

Hoss, You are correct. Its only happening with grouping and solr cloud options. For example if I send a query like q=*:*&group=true&group.field=language&fq={!pf1}. 
Sorry. The confusion earlier happened because I had some default grouping enabled for all the queries in the solrconfig select handler.
Updated the title accordingly.
                
      was (Author: vnathan):
    You are correct. Its only happening with grouping and solr cloud options. For example if I send a query like q=*:*&group=true&group.field=language&fq={!pf1}. 
Sorry. The confusion earlier happened because I had some default grouping enabled for all the queries in the solrconfig select handler.
Updated the title accordingly.
                  
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-3960.
----------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.1

Thanks for hte review yonik, and thanks Nathan for the bug report.

Committed revision 1413975. - trunk
Committed revision 1413983. - 4x

                
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>            Assignee: Hoss Man
>              Labels: patch
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3960.patch, SOLR-3960.patch
>
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Comment Edited] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud for queries with grouping

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478903#comment-13478903 ] 

Nathan Visagan edited comment on SOLR-3960 at 10/18/12 10:56 AM:
-----------------------------------------------------------------

You are correct. Its only happening with grouping and solr cloud options. For example if I send a query like q=*:*&group=true&group.field=language&fq={!pf1}. 
Sorry. The confusion earlier happened because I had some default grouping enabled for all the queries in the solrconfig select handler.
Updated the title accordingly.
                
      was (Author: vnathan):
    You are correct. Its only happening with grouping and solr cloud options. For example if I send a query like q=*:*&group=true&group.field=language&fq={!pf1}. 
Sorry. The confusion earlier happened because I had some default grouping enabled for all the queries in the solrconfig select handler.
                  
> Searching: PostFilter plugins ignored by solr cloud for queries with grouping
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478249#comment-13478249 ] 

Hoss Man commented on SOLR-3960:
--------------------------------

Nathan: just to clarify, you said...

bq. When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.

but then you go on to say...

bq. I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() 

which makes it sound like this problem is specific to using the _grouping_ features combined with distributed search (ie: solr cloud) and not a general problem with all distributed search.

can you please confirm/clarify that? when you do a regular search, w/o using grouping, then do you see your postfilter used in solrcloud?

It would also help if you could provide a simple example of the problem you are seeing that didn't require using your custom component QParserPlugin -- so we can rule out that there isn't anything odd in how your custom code.  a JUnit test would be ideal, but even providing an example URL using the example configs that are included with solr showing the problem would be helpful. (eg: the frange qparser can be used as a PostFilter)




                
> Searching: PostFilter plugins ignored by solr cloud
> ---------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3960) Searching: PostFilter plugins ignored by solr cloud

Posted by "Nathan Visagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Visagan updated SOLR-3960:
---------------------------------

    Description: 
When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

  was:
When specifying the cloud options (-DzkRun -DnumShards=n) solr query does not consider the PostFilter.
For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
When I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter. pf is an instance of SolrIndexSearcher.ProcessedFilter. 

    
> Searching: PostFilter plugins ignored by solr cloud
> ---------------------------------------------------
>
>                 Key: SOLR-3960
>                 URL: https://issues.apache.org/jira/browse/SOLR-3960
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SolrCloud
>    Affects Versions: 4.0-BETA
>         Environment: Linux / jre 1.6
>            Reporter: Nathan Visagan
>              Labels: patch
>
> When specifying the cloud options (-DzkRun -DnumShards=n) in solr startup parameters, solr search does not consider any PostFilters.
> For example, I have implemented a PostFilter and wrapped that in my QParserPlugin sub class. Then in the solr query I am using fq to apply post filtering by specifying fq={!pf1} where pf1 is the name of my QParserPlugin. This all works well in solr and not in solr cloud. 
> I debugged and figured out that org.apache.solr.search.Grouping.execute() method is called by the non cloud instance. This considers pf.PostFilter which is the collection of all PostFilters whereas org.apache.solr.search.grouping.CommandHandler.execute() which is called by the solr cloud instance ignores the pf.PostFilter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org