You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Steve Eynon (JIRA)" <ji...@apache.org> on 2011/09/03 10:40:09 UTC
[jira] [Created] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Have Submit documentation explicitly state when the disabled attribute is evaluated
-----------------------------------------------------------------------------------
Key: TAP5-1628
URL: https://issues.apache.org/jira/browse/TAP5-1628
Project: Tapestry 5
Issue Type: Improvement
Components: documentation
Affects Versions: 5.3
Reporter: Steve Eynon
Priority: Trivial
The "disabled" attribute for a Submit button is currently loosely
documented as :
" ... Further, a disabled field ignores any value in the request when
the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon
form submission and the "selected" event is only fired should it
evaluate to 'false'."
For this stumped us in work today for a good half hour - it was
because we weren't @Persist'ing our disabled attribute. Our expression
was t:disabled="!myObject" and of course 'myObject' because null /
false on form submission. As our submit button was enabled and the
form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100206#comment-13100206 ]
Bob Harner commented on TAP5-1628:
----------------------------------
Okay, I get it. How about the following:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted
the bound value is checked again and, if true, the field's
value is ignored (not even validated) and the component's
events are not fired.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100225#comment-13100225 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
Yep, sounds good! Thanks!
Though I prefer the term similar to "re-evaluated" over "checked" so you know the whole expression is, err, evaluated (!), and it's not just some cached value being checked. But anything is better nothing, so, um, cheers!
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101134#comment-13101134 ]
Hudson commented on TAP5-1628:
------------------------------
Integrated in tapestry-trunk-freestyle #511 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/511/])
TAP5-1628 minor rewording (javadoc only)
bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1167084
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100129#comment-13100129 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
Um, I mean, "...for does this not effectively..."
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100129#comment-13100129 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
Um, I mean, "...for does this not effectively..."
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101112#comment-13101112 ]
Bob Harner commented on TAP5-1628:
----------------------------------
Okay, changed to:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted, the
bound value is evaluated again and, if true, the field's value is
ignored (not even validated) and the component's events are not fired.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100225#comment-13100225 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
Yep, sounds good! Thanks!
Though I prefer the term similar to "re-evaluated" over "checked" so you know the whole expression is, err, evaluated (!), and it's not just some cached value being checked. But anything is better nothing, so, um, cheers!
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098617#comment-13098617 ]
Hudson commented on TAP5-1628:
------------------------------
Integrated in tapestry-trunk-freestyle #506 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/506/])
Fixed TAP5-1628 (Have Submit documentation explicitly state when the disabled attribute is evaluated), javadoc changes only.
bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165938
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098617#comment-13098617 ]
Hudson commented on TAP5-1628:
------------------------------
Integrated in tapestry-trunk-freestyle #506 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/506/])
Fixed TAP5-1628 (Have Submit documentation explicitly state when the disabled attribute is evaluated), javadoc changes only.
bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165938
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner closed TAP5-1628.
----------------------------
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner closed TAP5-1628.
----------------------------
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100122#comment-13100122 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
It is less to do with the @Persist annotation and more to do with not knowing the disabled parameter is used / re-evaluated during the server-side form submit event.
Once the <input> element has rendered, it is not obvious the disabled parameter will ever be used / re-evaluated again, for I would expect it's sole purpose is to only render the HTML "disabled" attribute.
I guess I should (have) really ask(ed) why the disabled parameter is evaluated again on form submission, for this not effectively prevent you from re-enabling the component (via javascript) on the web page?
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101134#comment-13101134 ]
Hudson commented on TAP5-1628:
------------------------------
Integrated in tapestry-trunk-freestyle #511 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/511/])
TAP5-1628 minor rewording (javadoc only)
bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1167084
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner resolved TAP5-1628.
------------------------------
Resolution: Fixed
Fix Version/s: 5.3
Assignee: Bob Harner
Fixed in rev 1165938, although with different text:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted, disabled
fields' values are ignored (not even validated), and the component's
events, if any, are not fired.
But I'm not sure a better description of the disabled parameter helps people know when to apply the @Persist annotation.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101112#comment-13101112 ]
Bob Harner commented on TAP5-1628:
----------------------------------
Okay, changed to:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted, the
bound value is evaluated again and, if true, the field's value is
ignored (not even validated) and the component's events are not fired.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Eynon updated TAP5-1628:
------------------------------
Description:
The "disabled" attribute for a Submit button is currently loosely documented as :
" ... Further, a disabled field ignores any value in the request when the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
was:
The "disabled" attribute for a Submit button is currently loosely
documented as :
" ... Further, a disabled field ignores any value in the request when
the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon
form submission and the "selected" event is only fired should it
evaluate to 'false'."
For this stumped us in work today for a good half hour - it was
because we weren't @Persist'ing our disabled attribute. Our expression
was t:disabled="!myObject" and of course 'myObject' because null /
false on form submission. As our submit button was enabled and the
form submitted, we saw no reason for the event not to fire.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Priority: Trivial
> Labels: submit
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100206#comment-13100206 ]
Bob Harner commented on TAP5-1628:
----------------------------------
Okay, I get it. How about the following:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted
the bound value is checked again and, if true, the field's
value is ignored (not even validated) and the component's
events are not fired.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100122#comment-13100122 ]
Steve Eynon commented on TAP5-1628:
-----------------------------------
It is less to do with the @Persist annotation and more to do with not knowing the disabled parameter is used / re-evaluated during the server-side form submit event.
Once the <input> element has rendered, it is not obvious the disabled parameter will ever be used / re-evaluated again, for I would expect it's sole purpose is to only render the HTML "disabled" attribute.
I guess I should (have) really ask(ed) why the disabled parameter is evaluated again on form submission, for this not effectively prevent you from re-enabling the component (via javascript) on the web page?
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Eynon updated TAP5-1628:
------------------------------
Description:
The "disabled" attribute for a Submit button is currently loosely documented as :
" ... Further, a disabled field ignores any value in the request when the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
was:
The "disabled" attribute for a Submit button is currently loosely
documented as :
" ... Further, a disabled field ignores any value in the request when
the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon
form submission and the "selected" event is only fired should it
evaluate to 'false'."
For this stumped us in work today for a good half hour - it was
because we weren't @Persist'ing our disabled attribute. Our expression
was t:disabled="!myObject" and of course 'myObject' because null /
false on form submission. As our submit button was enabled and the
form submitted, we saw no reason for the event not to fire.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Priority: Trivial
> Labels: submit
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Harner resolved TAP5-1628.
------------------------------
Resolution: Fixed
Fix Version/s: 5.3
Assignee: Bob Harner
Fixed in rev 1165938, although with different text:
If true, then the field will render out with a disabled attribute
(to turn off client-side behavior). When the form is submitted, disabled
fields' values are ignored (not even validated), and the component's
events, if any, are not fired.
But I'm not sure a better description of the disabled parameter helps people know when to apply the @Persist annotation.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Assignee: Bob Harner
> Priority: Trivial
> Labels: submit
> Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira