You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/12/11 09:09:08 UTC

[GitHub] tajo pull request: TAJO-2017: Replace manual array copy with Colle...

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/907

    TAJO-2017: Replace manual array copy with Collection

    Copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll().

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-2017

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #907
    
----
commit 1df496222939e4e9ab4cce7c5acd9d221ccc3963
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-12-11T08:05:03Z

    initial commit

commit 53b40e9265215b3980ebb8ab074b8fe15a58c63e
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-12-11T08:08:01Z

    rollback unnecessarily changed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2017: Replace manual array copy with Colle...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/907


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2017: Replace manual array copy with Colle...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/907#issuecomment-184073041
  
    +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2017: Replace manual array copy with Colle...

Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:

    https://github.com/apache/tajo/pull/907#issuecomment-184068043
  
    @jinossy Hi! I rebase this patch. Thanks for your notice. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-2017: Replace manual array copy with Colle...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/907#issuecomment-184065035
  
    Would you rebase your patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---