[jira] [Commented] (NUMBERS-68) Numbers are "value" objects

["Eric Barnhill (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUMBERS-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382030#comment-16382030 ] 

Eric Barnhill commented on NUMBERS-68:
--------------------------------------

Do we agree that the list of bullet points on this article is necessary and sufficient? Then the action plan can just be to tick these off one by one.

Some of them I understand and some are outside my scope of experience (for example I would not know best practices for "The {{toString()}} method must return a formally-defined string fully exposing the state and nothing else."). So it would be good if we could work together on some of these.

It brings to the fore some interesting issues, for example Complex() currently has no compareTo, but now that it is brought to my attention, I suspect it should . So overall I think it would benefit the class to pursue this.

> Numbers are "value" objects
> ---------------------------
>
>                 Key: NUMBERS-68
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-68
>             Project: Commons Numbers
>          Issue Type: Task
>          Components: complex, fraction, quaternion
>            Reporter: Gilles
>            Priority: Major
>              Labels: api, design, gsoc2018
>             Fix For: 1.0
>
>
> Consider making _value_ classes {{final}}.
> See http://blog.joda.org/2014/03/valjos-value-java-objects.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)