You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/17 17:26:10 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2
xiaoxiang781216 opened a new pull request, #6290:
URL: https://github.com/apache/incubator-nuttx/pull/6290
## Summary
unify the timer process logic as other tcp state
## Impact
Same as before
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6290:
URL: https://github.com/apache/incubator-nuttx/pull/6290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #6290:
URL: https://github.com/apache/incubator-nuttx/pull/6290#discussion_r875786926
##########
net/tcp/tcp_timer.c:
##########
@@ -470,7 +452,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
#endif
/* Update for the next probe */
- conn->keeptime = clock_systime_ticks();
+ conn->keeptimer = conn->keepintl;
Review Comment:
```suggestion
conn->keeptimer = conn->keepintvl;
```
CI complained about this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6290: net/tcp: Use the decrease timer in TCP_TIME_WAIT/TCP_FIN_WAIT_2
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6290:
URL: https://github.com/apache/incubator-nuttx/pull/6290#discussion_r876049735
##########
net/tcp/tcp_timer.c:
##########
@@ -470,7 +452,7 @@ void tcp_timer(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
#endif
/* Update for the next probe */
- conn->keeptime = clock_systime_ticks();
+ conn->keeptimer = conn->keepintl;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org