You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "javeme (via GitHub)" <gi...@apache.org> on 2023/11/27 09:33:02 UTC

Re: [PR] fix HBase PrefixFilter bug [incubator-hugegraph]

javeme commented on code in PR #2364:
URL: https://github.com/apache/incubator-hugegraph/pull/2364#discussion_r1405867595


##########
hugegraph-server/hugegraph-hbase/src/main/java/org/apache/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -391,7 +391,10 @@ default R scan(String table, long limit) {
          * Scan records by rowkey prefix from a table
          */
         default R scan(String table, byte[] prefix) {
-            return this.scan(table, prefix, true, prefix);
+            // TODO: setRowPrefixFilter deprecated since HBase 2.5.0,
+            // will be removed in 4.0.0,setStartStopRowForPrefixScan(byte[]) instead.

Review Comment:
   expect style like this:
   ```
   /*
    * TODO: setRowPrefixFilter() deprecated since HBase 2.5.0, will be removed in 4.0.0,
    * use setStartStopRowForPrefixScan(byte[]) instead.
    * /
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org