You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/18 04:03:25 UTC

[GitHub] [flink] 1996fanrui opened a new pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

1996fanrui opened a new pull request #18385:
URL: https://github.com/apache/flink/pull/18385


   ## What is the purpose of the change
   
   Reuse tpc connections between taskmanagers
   
   ## Brief change log
   
   Reuse tpc connections between taskmanagers.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   Added test that PartitionRequestClientFactoryTest#testReuseNettyPartitionRequestClient.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski closed pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

Posted by GitBox <gi...@apache.org>.
pnowojski closed pull request #18385:
URL: https://github.com/apache/flink/pull/18385


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #18385:
URL: https://github.com/apache/flink/pull/18385#issuecomment-1015173085


   Hey @1996fanrui , unfortunately as this is a change introducing new feature, we shouldn't port it to the previous branches. I'm closing this PR. This feature will have to wait for 1.15.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18385:
URL: https://github.com/apache/flink/pull/18385#issuecomment-1015053663


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1ee2f3b49616b0c1aaaf8d8f78d93c93ae6fc2db",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29607",
       "triggerID" : "1ee2f3b49616b0c1aaaf8d8f78d93c93ae6fc2db",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ee2f3b49616b0c1aaaf8d8f78d93c93ae6fc2db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29607) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18385:
URL: https://github.com/apache/flink/pull/18385#issuecomment-1015053663






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #18385: [FLINK-22643][network] Reuse tpc connections between taskmanagers

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18385:
URL: https://github.com/apache/flink/pull/18385#issuecomment-1015281310


   Thanks for your clarification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org