[GitHub] [knox] smolnar82 commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #249: KNOX-2213 - Service Discovery Support for CM UI, API
URL: https://github.com/apache/knox/pull/249#discussion_r374108129
 
 

 ##########
 File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscovery.java
 ##########
 @@ -280,7 +304,17 @@ private static ApiRoleList getRoles(RolesResourceApi rolesResourceApi,
                                       String serviceName) {
     ApiRoleList roles = null;
     try {
-      roles = rolesResourceApi.readRoles(clusterName, serviceName, "", VIEW_SUMMARY);
+      /* Populate roles for CM Service since they are not discoverable */
+      if(CM_SERVICE_TYPE.equalsIgnoreCase(serviceName)) {
+        final ApiRoleList roleList = new ApiRoleList();
 
 Review comment:
   There is already an `ApiRoleList` type local variable - `roles` - which should be re-used and initiated here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services