You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/30 11:23:44 UTC

[GitHub] [spark] liucht-inspur opened a new pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

liucht-inspur opened a new pull request #28680:
URL: https://github.com/apache/spark/pull/28680


   
   ### What changes were proposed in this pull request?
   update the url "../images/sort_asc.png"
   to"./images/sort_asc.png"
   
   ### Why are the changes needed?
   
   The icon could not find the correct path
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   
   ### How was this patch tested?
   Fixed existing test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636447628






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636465725






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] liucht-inspur commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636842905


   ok,thanks @redsanket @sarutak ,I am doing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636317390


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636848505


   @liucht-inspur I confirmed this issue happens for `branch-2.4`.
   This issue is resolved in `master` by overriding the corresponding style using CSS.
   https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css#L46
   
   If you open a PR for `branch-2.4`, could you consider the same solution rather than modify the `min.css`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636597515


   @liucht-inspur 
   It's funny that those icons are found in the current `master`.
   <img width="1406" alt="history" src="https://user-images.githubusercontent.com/4736016/83373973-258cd600-a405-11ea-82ce-2239274bbe76.png">
   <img width="1426" alt="executors" src="https://user-images.githubusercontent.com/4736016/83373977-2a518a00-a405-11ea-8aef-40c2c00038ed.png">
   
   Could you show us the console log of browser and screen shots of before this change?
   Also, could you tell us how can we reproduce this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636317486


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636465481


   **[Test build #123342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123342/testReport)** for PR 28680 at commit [`2411509`](https://github.com/apache/spark/commit/24115099b1c0fcda8dee7550a6647dd315cbab6c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] redsanket commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
redsanket commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636806979


   @liucht-inspur looks like your history server is 2.4.5? Are we referring to master or an earlier spark 2.4.5 version?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636447257






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636317390


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak edited a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636848505


   @liucht-inspur I confirmed this issue happens for `branch-2.4`.
   This issue is resolved in `master` by overriding the corresponding style using CSS.
   https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css#L46
   
   If you'll open a PR for `branch-2.4`, could you consider the same solution rather than modify the `min.css`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636848505


   @liucht-inspur I confirmed this issue happen for `branch-2.4`.
   This issue is resolved in `master` by overriding the corresponding style using CSS.
   https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/webui-dataTables.css#L46
   
   If you'll open a PR for `branch-2.4`, could you consider the same solution rather than modify the `min.css`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] liucht-inspur closed pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
liucht-inspur closed pull request #28680:
URL: https://github.com/apache/spark/pull/28680


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636447628






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636317486


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636447497


   **[Test build #123342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123342/testReport)** for PR 28680 at commit [`2411509`](https://github.com/apache/spark/commit/24115099b1c0fcda8dee7550a6647dd315cbab6c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] liucht-inspur commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636684197


   hi @sarutak the console log of browser is this:
   
   ![image](https://user-images.githubusercontent.com/28332082/83388973-fcc70980-a421-11ea-93a0-34cfd4193169.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636447497


   **[Test build #123342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123342/testReport)** for PR 28680 at commit [`2411509`](https://github.com/apache/spark/commit/24115099b1c0fcda8dee7550a6647dd315cbab6c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636465725






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] liucht-inspur commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
liucht-inspur commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636665331


   @sarutak 
   Thanks for your response .
   before this change
   history server page like this:
   ![image](https://user-images.githubusercontent.com/28332082/83384959-e36e8f00-a41a-11ea-85fd-b213544f3558.png)
   
   Executors page like this:
   ![image](https://user-images.githubusercontent.com/28332082/83385058-17e24b00-a41b-11ea-8bad-dcad3c641eca.png)
   
   In the current master css code like this:
   ![image](https://user-images.githubusercontent.com/28332082/83385213-6b549900-a41b-11ea-8654-869d58429def.png)
   and the icons image really path:
   ![image](https://user-images.githubusercontent.com/28332082/83385370-ace54400-a41b-11ea-91e9-0b3fd09174c1.png)
   
   so,The icons image url should be changed to ". /images/ XXX " instead of "../images/ XXX "


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28680:
URL: https://github.com/apache/spark/pull/28680#issuecomment-636828682


   @liucht-inspur As @redsanket pointed out, your history server seems to be version `2.4.5`, while this PR is for `master`.
   If this issue occurs for `2.4.5`, could you close this PR and open another PR for `branch-2.4`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org