You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/29 16:28:11 UTC

[GitHub] [spark] srowen commented on a change in pull request #28063: [SPARK-31293][DSTREAMS][Kinesis][DOC] Fix wrong examples and help messages for Kinesis integration

srowen commented on a change in pull request #28063: [SPARK-31293][DSTREAMS][Kinesis][DOC] Fix wrong examples and help messages for Kinesis integration
URL: https://github.com/apache/spark/pull/28063#discussion_r399820755
 
 

 ##########
 File path: external/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
 ##########
 @@ -78,7 +78,7 @@ object KinesisWordCountASL extends Logging {
     if (args.length != 3) {
       System.err.println(
         """
-          |Usage: KinesisWordCountASL <app-name> <stream-name> <endpoint-url> <region-name>
 
 Review comment:
   I'm probably mixed up but you remove the region name arg here, but then add it to the example command?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org