[GitHub] [netbeans] borisheithecker commented on issue #1611: Fix unittest ProxyClassLoaderNB11PackageAnnotationsTest

[GitBox <gi...@apache.org>]

borisheithecker commented on issue #1611: Fix unittest ProxyClassLoaderNB11PackageAnnotationsTest
URL: https://github.com/apache/netbeans/pull/1611#issuecomment-549583784
 
 
   Yes, the package needs to be defined, too. Looks good to me.
   Regards,
   Boris
   
   On Sun, 3 Nov 2019 at 19:55, Matthias Bläsing <no...@github.com>
   wrote:
   
   > @borisheithecker <https://github.com/borisheithecker> please have a look
   > at this - the new Unittest ProxyClassLoaderNB11PackageAnnotationsTest fails
   > on JDK 8 (found by #1597 <https://github.com/apache/netbeans/pull/1597>).
   > I update the unittest and with this change I get:
   >
   > JDK8 without Fix: Test passes
   > JDK11 without Fix: Test fails
   > JDK8 with Fix: Test passes
   > JDK11 with Fix: Test passes
   >
   > This is IMHO the expected outcome. Does that look sane to you?
   > ------------------------------
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/netbeans/pull/1611
   > Commit Summary
   >
   >    - Fix unittest ProxyClassLoaderNB11PackageAnnotationsTest
   >
   > File Changes
   >
   >    - *M*
   >    platform/o.n.bootstrap/test/unit/src/org/netbeans/ProxyClassLoaderNB11PackageAnnotationsTest.java
   >    <https://github.com/apache/netbeans/pull/1611/files#diff-0> (3)
   >
   > Patch Links:
   >
   >    - https://github.com/apache/netbeans/pull/1611.patch
   >    - https://github.com/apache/netbeans/pull/1611.diff
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/netbeans/pull/1611?email_source=notifications&email_token=AECA34ICDXS3NY76K6KMGDLQR4NDFA5CNFSM4JIMS5U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWO3HCA>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AECA34JNZWQU7NQM2JWGOYTQR4NDFANCNFSM4JIMS5UQ>
   > .
   >
   
   
   -- 
   Boris Heithecker
   
   
   Dr. Boris Heithecker
   Lüneburger Str. 30
   28870 Ottersberg
   Festnetz: +49 4205 315834
   Mobil: +49 170 6137015
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists