You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/25 21:57:56 UTC

[GitHub] [trafficserver] ywkaras opened a new pull request #7624: Fix for issue #7607

ywkaras opened a new pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   https://github.com/apache/trafficserver/issues/7607
   
   Provides utilities for handling values that can be represented as either a string or a number in
   a 0-base range.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808619809


   [approve ci Clang-Analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-807874509


   Seems like overkill. To be honest, I don't want to maintain the utilities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras removed a comment on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808619809


   [approve ci Clang-Analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode edited a comment on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode edited a comment on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808475864


   I recommended bringing in `Lexicon` - http://docs.solidwallofcode.com/libswoc/code/Lexicon.en.html
   I wrote it for exactly this kind of thing for use in ATS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras removed a comment on pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-810293240


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-807591181


   The CodeOrStr template may also be useful to efficiently handle sets of MIME headers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808307369


   What do you propose as an alternative approach to resolve this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808662258


   i"d just move the current strcmp logic into the callback function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-810402925


   https://i.gifer.com/HJ2q.gif


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808475864


   I recommended bringing in `Lexicon` - http://docs.solidwallofcode.com/libswoc/code/Lexicon.en.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808606429


   [approve ci Clang-Analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-810293240


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808577165


   I knew it was too good to be true that I'd get to overload the comma operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras removed a comment on pull request #7624: Fix for issue #7607

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624#issuecomment-808606429


   [approve ci Clang-Analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #7624: Fix for issue #7607 (efficient mapping between enum values and strings)

Posted by GitBox <gi...@apache.org>.
ywkaras closed pull request #7624:
URL: https://github.com/apache/trafficserver/pull/7624


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org