[GitHub] [flink] 1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint

[GitBox <gi...@apache.org>]

1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/8741#discussion_r298973236
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
 ##########
 @@ -30,12 +29,13 @@ export FLINK_IMAGE_NAME=test_kubernetes_embedded_job
 export OUTPUT_VOLUME=${TEST_DATA_DIR}/out
 export OUTPUT_FILE=kubernetes_wc_out
 export FLINK_JOB_PARALLELISM=1
-export FLINK_JOB_ARGUMENTS='"--output", "/cache/kubernetes_wc_out"'
+export FLINK_JOB_ARGUMENTS='"--output", "/tmp/kubernetes_wc_out"'
+export FLINK_APPLICATION_NAME="test-application"
 
 function cleanup {
-    kubectl delete job flink-job-cluster
-    kubectl delete service flink-job-cluster
-    kubectl delete deployment flink-task-manager
+    kubectl delete job ${FLINK_APPLICATION_NAME}-master
+    kubectl delete service ${FLINK_APPLICATION_NAME}-master
 
 Review comment:
   I think better to use a suffix (instead of `-master`) that is consistent with the template prefix (currently `job-cluster`).
   
   You may consider something like `job-manager` too, for both template file names and Kubernetes resources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services