[GitHub] [netbeans] jtulach commented on a diff in pull request #4795: Use frgaal compiler to compile NetBeans

["jtulach (via GitHub)" <gi...@apache.org>]

jtulach commented on code in PR #4795:
URL: https://github.com/apache/netbeans/pull/4795#discussion_r1161680325


##########
platform/api.search/src/org/netbeans/modules/search/matcher/BufferedCharSequence.java:
##########
@@ -170,12 +167,9 @@ private BufferedCharSequence(BufferedCharSequence bufferedCharSequence) {
     @Override
     @SuppressWarnings("FinalizeDeclaration")
     protected void finalize() throws Throwable {
-        try {

Review Comment:
   One of the features of [frgaal](http://frgaal.org) is that it can report _"future deprecations"_ like [here](https://github.com/apache/netbeans/actions/runs/4657374401/jobs/8241911775?pr=4795#step:6:8204) - the compiler contains list of all deprecated methods up to JDK 20 and can emit warnings for each of them. When the module is compiled with `-Werror` one has to fix such _"future warnings"_ or `@SuppressWarnings` them.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists