You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "j1wonpark (via GitHub)" <gi...@apache.org> on 2026/08/18 00:27:45 UTC

[PR] [Hotfix][AMS] Stabilize optimizer scale-down floor test [amoro]

j1wonpark opened a new pull request, #4332:
URL: https://github.com/apache/amoro/pull/4332

   ## Why are the changes needed?
   
   `TestOptimizerScaleKeeper.testScaleDownRespectsFloor` intermittently failed with `expected: <1> but was: <2>`.
   
   The test created a DRA group with an unmet `min-parallelism` floor and then manually registered an optimizer. Group creation queues an immediate scale-keeper round, and floor recovery is intentionally not delayed by the configured scaling cadence. Depending on thread scheduling, the background keeper could register one optimizer before the test registered another.
   
   This is a test setup race rather than a failure in the production scale-down logic.
   
   ## Brief change log
   
   - Create the test DRA group with `min-parallelism=0`.
   - Raise the floor to `1` after the test optimizer is registered.
   - Assert that the live scale keeper does not trigger an unexpected scale-out during setup.
   
   ## How was this patch tested?
   
   - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
     - Reproduced the original failure deterministically: `expected: <1> but was: <2>`.
     - `TestOptimizerScaleKeeper`: 20 tests passed.
     - `testScaleDownRespectsFloor`: passed 10 consecutive runs.
   
   - [ ] Add screenshots for manual tests if appropriate
   
     Not applicable because this is a test-only change.
   
   - [x] Run test locally before making a pull request
   
     - `./mvnw -o -pl amoro-ams -DskipTests validate`
     - Spotless and Checkstyle passed.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Hotfix][AMS] Stabilize optimizer scale-down floor test [amoro]

Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 merged PR #4332:
URL: https://github.com/apache/amoro/pull/4332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Hotfix][AMS] Stabilize optimizer scale-down floor test [amoro]

Posted by "j1wonpark (via GitHub)" <gi...@apache.org>.
j1wonpark commented on PR #4332:
URL: https://github.com/apache/amoro/pull/4332#issuecomment-5321941733

   Hi @czy006  Could you please take a look at this DRA test hotfix? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org