[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied

["Niels Basjes (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830002#comment-17830002 ] 

Niels Basjes commented on RAT-362:
----------------------------------

I have been able to fix it and I've put up a pull request. https://github.com/apache/creadur-rat/pull/229

> plugin: .gitignore not correctly applied
> ----------------------------------------
>
>                 Key: RAT-362
>                 URL: https://issues.apache.org/jira/browse/RAT-362
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.16.1
>            Reporter: Arnout Engelen
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 0.17
>
>
> When I have a Maven project checked out in the directory '/foo', and I have a file called 'foo.md' in the root of that project, ignoring it by putting a '/foo.md' entry in the .gitignore file does not work.
> It is unclear whether this is an issue in the plugin or in de codeowners gitignore-reader dependency: the plugin is passing relative filenames (i.e. 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method don't make it too clear whether that is intended to accept absolute filenames, relative filename, or both.
> In this scenario, it seems to take the relative filename 'foo.md' and remove the project base directory '/foo' from it, leaving '/.md' (which then of course does not match the 'foo.md' from the .gitignore).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)