You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <br...@apache.org> on 2014/03/28 10:34:26 UTC

[LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Hi guys,

some of you have already discussed LANG-992. Do we need to push out an
immediate bugfix after we have resolved this? Is this issue fixed in
http://svn.apache.org/r1582585 ?

I'll have some time this weekend to create an RC.

Benedikt

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by Benedikt Ritter <br...@apache.org>.
The RC will have to wait until tomorrow, since I don't have enough time to
go through the hole process today :-)


2014-03-28 16:10 GMT+01:00 sebb <se...@gmail.com>:

> On 28 March 2014 15:06, Benedikt Ritter <br...@apache.org> wrote:
> > 2014-03-28 16:04 GMT+01:00 sebb <se...@gmail.com>:
> >
> >> On 28 March 2014 15:00, Benedikt Ritter <br...@apache.org> wrote:
> >> > 2014-03-28 14:50 GMT+01:00 sebb <se...@gmail.com>:
> >> >
> >> >> On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
> >> >> > Hi guys,
> >> >> >
> >> >> > some of you have already discussed LANG-992. Do we need to push
> out an
> >> >> > immediate bugfix after we have resolved this?
> >> >>
> >> >> Perhaps.
> >> >>
> >> >> > Is this issue fixed in http://svn.apache.org/r1582585 ?
> >> >>
> >> >> Yes, AFAIK.
> >> >>
> >> >> > I'll have some time this weekend to create an RC.
> >> >>
> >> >> If so, IMO it should be 3.3.2 rather than 3.4.
> >> >>
> >> >
> >> > Yes, usually I set the version to the next minor after doing a
> release.
> >> > That's why it has been set to 3.4-SNAPSHOT after 3.3.1
> >> >
> >> >
> >> >>
> >> >> There seems to be one new field:
> >> >>
> >> >> SystemUtils.IS_JAVA_1_8
> >> >>
> >> >
> >> > my opinion is, that the clirr report for a patch release should be
> empty.
> >> > In this case Clirr will show one info, so following this convention is
> >> > would be 3.4. OTOH a minor release should introduce a few more
> features
> >> > beside a new field...
> >>
> >> Exactly; this is such a trivial change I don't think it warrants a
> >> minor version bump.
> >> It could be considered as a bug fix (but not a regression, as is the
> >> case for the octal issue)
> >>
> >
> > Okay, I'll prepare 3.3.2 RC1 tomorrow morning.
>
> Thanks a lot!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by sebb <se...@gmail.com>.
On 28 March 2014 15:06, Benedikt Ritter <br...@apache.org> wrote:
> 2014-03-28 16:04 GMT+01:00 sebb <se...@gmail.com>:
>
>> On 28 March 2014 15:00, Benedikt Ritter <br...@apache.org> wrote:
>> > 2014-03-28 14:50 GMT+01:00 sebb <se...@gmail.com>:
>> >
>> >> On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
>> >> > Hi guys,
>> >> >
>> >> > some of you have already discussed LANG-992. Do we need to push out an
>> >> > immediate bugfix after we have resolved this?
>> >>
>> >> Perhaps.
>> >>
>> >> > Is this issue fixed in http://svn.apache.org/r1582585 ?
>> >>
>> >> Yes, AFAIK.
>> >>
>> >> > I'll have some time this weekend to create an RC.
>> >>
>> >> If so, IMO it should be 3.3.2 rather than 3.4.
>> >>
>> >
>> > Yes, usually I set the version to the next minor after doing a release.
>> > That's why it has been set to 3.4-SNAPSHOT after 3.3.1
>> >
>> >
>> >>
>> >> There seems to be one new field:
>> >>
>> >> SystemUtils.IS_JAVA_1_8
>> >>
>> >
>> > my opinion is, that the clirr report for a patch release should be empty.
>> > In this case Clirr will show one info, so following this convention is
>> > would be 3.4. OTOH a minor release should introduce a few more features
>> > beside a new field...
>>
>> Exactly; this is such a trivial change I don't think it warrants a
>> minor version bump.
>> It could be considered as a bug fix (but not a regression, as is the
>> case for the octal issue)
>>
>
> Okay, I'll prepare 3.3.2 RC1 tomorrow morning.

Thanks a lot!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by Benedikt Ritter <br...@apache.org>.
2014-03-28 16:04 GMT+01:00 sebb <se...@gmail.com>:

> On 28 March 2014 15:00, Benedikt Ritter <br...@apache.org> wrote:
> > 2014-03-28 14:50 GMT+01:00 sebb <se...@gmail.com>:
> >
> >> On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
> >> > Hi guys,
> >> >
> >> > some of you have already discussed LANG-992. Do we need to push out an
> >> > immediate bugfix after we have resolved this?
> >>
> >> Perhaps.
> >>
> >> > Is this issue fixed in http://svn.apache.org/r1582585 ?
> >>
> >> Yes, AFAIK.
> >>
> >> > I'll have some time this weekend to create an RC.
> >>
> >> If so, IMO it should be 3.3.2 rather than 3.4.
> >>
> >
> > Yes, usually I set the version to the next minor after doing a release.
> > That's why it has been set to 3.4-SNAPSHOT after 3.3.1
> >
> >
> >>
> >> There seems to be one new field:
> >>
> >> SystemUtils.IS_JAVA_1_8
> >>
> >
> > my opinion is, that the clirr report for a patch release should be empty.
> > In this case Clirr will show one info, so following this convention is
> > would be 3.4. OTOH a minor release should introduce a few more features
> > beside a new field...
>
> Exactly; this is such a trivial change I don't think it warrants a
> minor version bump.
> It could be considered as a bug fix (but not a regression, as is the
> case for the octal issue)
>

Okay, I'll prepare 3.3.2 RC1 tomorrow morning.


>
> >
> >>
> >> which will need the appropriate @since marker
> >>
> >
> > That's part of the documented release process and should be added by the
> > release manager (which will be me, if nobody else steps in :-)
> >
> >
> >>
> >> > Benedikt
> >> >
> >> > --
> >> > http://people.apache.org/~britter/
> >> > http://www.systemoutprintln.de/
> >> > http://twitter.com/BenediktRitter
> >> > http://github.com/britter
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by sebb <se...@gmail.com>.
On 28 March 2014 15:00, Benedikt Ritter <br...@apache.org> wrote:
> 2014-03-28 14:50 GMT+01:00 sebb <se...@gmail.com>:
>
>> On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
>> > Hi guys,
>> >
>> > some of you have already discussed LANG-992. Do we need to push out an
>> > immediate bugfix after we have resolved this?
>>
>> Perhaps.
>>
>> > Is this issue fixed in http://svn.apache.org/r1582585 ?
>>
>> Yes, AFAIK.
>>
>> > I'll have some time this weekend to create an RC.
>>
>> If so, IMO it should be 3.3.2 rather than 3.4.
>>
>
> Yes, usually I set the version to the next minor after doing a release.
> That's why it has been set to 3.4-SNAPSHOT after 3.3.1
>
>
>>
>> There seems to be one new field:
>>
>> SystemUtils.IS_JAVA_1_8
>>
>
> my opinion is, that the clirr report for a patch release should be empty.
> In this case Clirr will show one info, so following this convention is
> would be 3.4. OTOH a minor release should introduce a few more features
> beside a new field...

Exactly; this is such a trivial change I don't think it warrants a
minor version bump.
It could be considered as a bug fix (but not a regression, as is the
case for the octal issue)

>
>>
>> which will need the appropriate @since marker
>>
>
> That's part of the documented release process and should be added by the
> release manager (which will be me, if nobody else steps in :-)
>
>
>>
>> > Benedikt
>> >
>> > --
>> > http://people.apache.org/~britter/
>> > http://www.systemoutprintln.de/
>> > http://twitter.com/BenediktRitter
>> > http://github.com/britter
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by Benedikt Ritter <br...@apache.org>.
2014-03-28 14:50 GMT+01:00 sebb <se...@gmail.com>:

> On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
> > Hi guys,
> >
> > some of you have already discussed LANG-992. Do we need to push out an
> > immediate bugfix after we have resolved this?
>
> Perhaps.
>
> > Is this issue fixed in http://svn.apache.org/r1582585 ?
>
> Yes, AFAIK.
>
> > I'll have some time this weekend to create an RC.
>
> If so, IMO it should be 3.3.2 rather than 3.4.
>

Yes, usually I set the version to the next minor after doing a release.
That's why it has been set to 3.4-SNAPSHOT after 3.3.1


>
> There seems to be one new field:
>
> SystemUtils.IS_JAVA_1_8
>

my opinion is, that the clirr report for a patch release should be empty.
In this case Clirr will show one info, so following this convention is
would be 3.4. OTOH a minor release should introduce a few more features
beside a new field...


>
> which will need the appropriate @since marker
>

That's part of the documented release process and should be added by the
release manager (which will be me, if nobody else steps in :-)


>
> > Benedikt
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [LANG] NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

Posted by sebb <se...@gmail.com>.
On 28 March 2014 09:34, Benedikt Ritter <br...@apache.org> wrote:
> Hi guys,
>
> some of you have already discussed LANG-992. Do we need to push out an
> immediate bugfix after we have resolved this?

Perhaps.

> Is this issue fixed in http://svn.apache.org/r1582585 ?

Yes, AFAIK.

> I'll have some time this weekend to create an RC.

If so, IMO it should be 3.3.2 rather than 3.4.

There seems to be one new field:

SystemUtils.IS_JAVA_1_8

which will need the appropriate @since marker

> Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org