You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2019/12/18 07:43:00 UTC
Review Request 71924: ATLAS-3562: Hive metadata has the same
classification multiple times
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71924/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3562
https://issues.apache.org/jira/browse/ATLAS-3562
Repository: atlas
Description
-------
Put Lock on entity before its gets cached.
Moved GraphTransactionInterceptor.lockObjectAndReleasePostCommit(guid);
before code gets AtlasVertex for the entity guid.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ea5e6ab
Diff: https://reviews.apache.org/r/71924/diff/1/
Testing
-------
TESTING:
Testing done by sending 2 simultaneous curl resquests to associate same Classification to the same entity.
RESULT:
Classification gets associted with the entity only once.
Application throws exception for the other simultaneous curl request:
org.apache.atlas.exception.AtlasBaseException: invalid parameters: entity: <guid>, already associated with classification: <classification_name>
Thanks,
Mandar Ambawane
Re: Review Request 71924: ATLAS-3562: Hive metadata has the same
classification multiple times
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71924/#review219052
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 18, 2019, 7:43 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71924/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2019, 7:43 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3562
> https://issues.apache.org/jira/browse/ATLAS-3562
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Put Lock on entity before its gets cached.
>
> Moved GraphTransactionInterceptor.lockObjectAndReleasePostCommit(guid);
> before code gets AtlasVertex for the entity guid.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ea5e6ab
>
>
> Diff: https://reviews.apache.org/r/71924/diff/1/
>
>
> Testing
> -------
>
> TESTING:
> Testing done by sending 2 simultaneous curl resquests to associate same Classification to the same entity.
>
> RESULT:
>
> Classification gets associted with the entity only once.
>
> Application throws exception for the other simultaneous curl request:
> org.apache.atlas.exception.AtlasBaseException: invalid parameters: entity: <guid>, already associated with classification: <classification_name>
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 71924: ATLAS-3562: Hive metadata has the same
classification multiple times
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71924/#review219055
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Dec. 17, 2019, 11:43 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71924/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2019, 11:43 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3562
> https://issues.apache.org/jira/browse/ATLAS-3562
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Put Lock on entity before its gets cached.
>
> Moved GraphTransactionInterceptor.lockObjectAndReleasePostCommit(guid);
> before code gets AtlasVertex for the entity guid.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ea5e6ab
>
>
> Diff: https://reviews.apache.org/r/71924/diff/1/
>
>
> Testing
> -------
>
> TESTING:
> Testing done by sending 2 simultaneous curl resquests to associate same Classification to the same entity.
>
> RESULT:
>
> Classification gets associted with the entity only once.
>
> Application throws exception for the other simultaneous curl request:
> org.apache.atlas.exception.AtlasBaseException: invalid parameters: entity: <guid>, already associated with classification: <classification_name>
>
>
> Thanks,
>
> Mandar Ambawane
>
>