You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/12 08:58:27 UTC
[GitHub] [shardingsphere] soulasuna opened a new issue #11282: Code optimization for shardingsphere-shadow project
soulasuna opened a new issue #11282:
URL: https://github.com/apache/shardingsphere/issues/11282
## Code optimization for shardingsphere-shadow project
Optimization goal to improve code robustness and readability
## Optimization direction
- Perform type judgment before forced type conversion to avoid type conversion failure.
- Reduce nested if judgments. The logic is clearer and easier to read.
- Optimize large methods with complex logic and increase the readable lines for multiple small methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on issue #11282: Code optimization for shardingsphere-shadow project
Posted by GitBox <gi...@apache.org>.
soulasuna commented on issue #11282:
URL: https://github.com/apache/shardingsphere/issues/11282#issuecomment-894194206
Refactor shadow. see #11661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna closed issue #11282: Code optimization for shardingsphere-shadow project
Posted by GitBox <gi...@apache.org>.
soulasuna closed issue #11282:
URL: https://github.com/apache/shardingsphere/issues/11282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org