[GitHub] [cxf] reta commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

[GitBox <gi...@apache.org>]

reta commented on PR #1033:
URL: https://github.com/apache/cxf/pull/1033#issuecomment-1324464561

   Hey @aziubin, thanks a lot reporting the issue and trying to fix it. I was able to craft the test case and reproduce it (again, because of your very detailed report). 
   
   Sadly the solution you are suggesting is covering only one specific variation of the problem. For example, when argument is removed in between (last argument is omitted, we would end up with `wrong number of arguments`). Another issue is primitive types: by stripping the `REMOVED_MARKER` placeholder you are effectively trading it for `null` which does not play well with primitive Java type (in this particular case, imagine that argument in the middle is `int`, we end up with `argument type mismatch` anyway).
   
   I don't have the solution off the top of my head, also it would be great to consult the SOAP spec regarding the cases when operation parameters are omitted.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org