You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/06/12 16:16:42 UTC
[GitHub] [superset] kgabryje opened a new pull request, #24363: fix: deck.gl Scatterplot min/max radius
kgabryje opened a new pull request, #24363:
URL: https://github.com/apache/superset/pull/24363
### SUMMARY
Fixes setting min/max radius in deck.gl Scatterplot chart. Sometimes when user changed the value the circles would disappear, because the input was actually treated as a string and deck.gl expects a number
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1728" alt="image" src="https://github.com/apache/superset/assets/15073128/8744a456-54c3-4f97-bd8c-610eab3123f9">
After:
<img width="1728" alt="image" src="https://github.com/apache/superset/assets/15073128/2fbdfc7a-b484-41b5-a6d3-8d44b9e9ca42">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24363: fix: deck.gl Scatterplot min/max radius
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24363:
URL: https://github.com/apache/superset/pull/24363#issuecomment-1587769077
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24363](https://app.codecov.io/gh/apache/superset/pull/24363?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0739330) into [master](https://app.codecov.io/gh/apache/superset/commit/e0253a4b2572045643de4b824875a8f366db4254?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0253a4) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0739330 differs from pull request most recent head b5e85c7. Consider uploading reports for the commit b5e85c7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24363 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 1903 1903
Lines 74564 74564
Branches 8107 8107
=======================================
Hits 51485 51485
Misses 20968 20968
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.62% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...preset-chart-deckgl/src/layers/Scatter/Scatter.jsx](https://app.codecov.io/gh/apache/superset/pull/24363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL1NjYXR0ZXIvU2NhdHRlci5qc3g=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #24363: fix: deck.gl Scatterplot min/max radius
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #24363:
URL: https://github.com/apache/superset/pull/24363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org